ENH: Review connected-component buffer size guarantees

Abierto
#1,928 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 6 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
32/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp

Línea de trabajo

Start by reading ConnectedComponentEngine and the linked simplnx #1764 change, then trace its 2D row, tile, replay and finalization buffers, 3D plane and grouped-transfer buffers, and ScratchBuffer<T> callers. The issue asks for agreement on exact allocation guarantees, growing run and label data, fallback behavior, and test ownership before choosing an implementation. Done means a reviewed plan covering representative 2D/3D cases, both storage modes, actual disk-backed storage, runtime and memory, and preserved output, error, and cancellation behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement Out-of-Core

Summary

Review the data-sized working buffers in ConnectedComponentEngine and establish which buffers need exact element-count allocation under the agreed data-payload accounting rule. This work is deferred from simplnx #1764 to a separate branch. The intended scope, including dynamically growing run and label state, needs agreement before implementation.

Mike's review note includes algorithm working arrays in data payload and names the connected-component engine. The engine uses existing std::vector buffers in its 2D and 3D paths. In the 2D path, the planner counts a requested number of run elements, while std::vector::reserve only promises a capacity of at least that number. The 2D value is a planning target; it is not itself a working-memory reservation. The 3D path also uses vectors for some buffers associated with working reservations.

These vectors existed before the accounting change in #1764. This observation does not establish that a supported standard library has allocated extra capacity or that a user has encountered a memory overrun. Normal allocator overhead is outside the payload accounting rule, and the rule does not cap the whole process.

Inspect the 2D row, tile, replay and finalization buffers and the 3D plane and grouped-transfer buffers. Decide separately how the rule applies to growing run, union-find and label data and to the existing low-memory fallback. The generic ScratchBuffer<T> currently uses std::vector for non-bool types, so its name alone does not establish an exact-capacity guarantee. Avoid changing it globally without reviewing its other callers.

The engine serves the Connected Component Image Filter, Threshold Maximum Connected Components Image Filter, and Morphological Watershed Image Filter. It runs with in-memory as well as out-of-core stores. Preserve output, error and cancellation behavior; check runtime and memory in both storage modes. Use independent small label/count expectations, representative 2D and 3D cases, tight and sufficient allowances, and tests that witness actual disk-backed storage. Verify which engine path each test reaches. Review proposed buffer ownership and test strategy before selecting an implementation.

Lenguaje dominante
C++
Estrellas
18
Forks
15
Merge medio
4 d 23 h
PR fusionados (30 d)
42

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de BlueQuartzSoftware/simplnx

Todos los issues de BlueQuartzSoftware/simplnx

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.