Inconsistency with new instance SVG icon acceptance
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start at the New instance flow's icon upload control and trace how its file picker filters image types, then compare that with the validation used when creating an instance. The issue also asks for an audit of other Modrinth UI flows, so identify which upload controls share the mismatch. Done means unsupported formats such as SVG cannot be selected where creation rejects them, with the picker and validation criteria aligned.
由索引模型根據 Issue 內容生成。
描述
Please confirm the following.
- I checked the existing issues for duplicate problems
- I have tried resolving the issue using the support portal
- I have ensured my Modrinth App installation is up to date
What version of the Modrinth App are you using?
0.22.0
What operating systems are you seeing the problem on?
MacOS
Describe the bug
When creating a new instance with a custom setup, SVG files are accepted via the Upload button for the instance icon, and render properly within the modal. However, when the Create instance button is selected, an error toast appears reading "An error occurred / invalid input: SVG instance icons are not supported", and instance creation fails. The initial acceptance of SVGs in the icon upload flow is misleading, and should be rejected so that progress isn't unexpectedly lost when creating an instance.
Steps to reproduce
- Go to the Home tab
- Under Library, select the New instance button
- Choose the Custom setup instance type
- Select the Upload button, and upload an SVG file
- Select the Create instance button
- See the error toast appear
Expected behavior
SVG files are unselectable in the Upload instance icon file picker.
Additional context
- This issue is likely present on all OS versions, and may be present in other Modrinth UI (e.g. web) where instance icons are accepted. These should be audited too to make sure behavior is consistent, especially for more-impactful situations like mod release flows to prevent even more lost progress.
- The criteria for all accepted file types in the Upload icon file picker should be synchronized with the actual accepted file types to keep these behaviors consistent. For example, it's possible the file picker accepts all image types including SVG and HEIC, whereas actual instance creation may only work with more standard file types like PNG and JPG. I haven't checked any actual code implementation for these claims.
- 主要語言
- Rust
- 星號
- 2.5k
- 分支
- 663
- 平均合併
- 2 天 11 小時
- 30 天內合併 PR
- 122
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
modrinth/code 的其他 Issue
-
app
難度 2/5 1-3 小時 新手友好度 70/100
維護者通常 1 天內回覆
-
website
難度 2/5 1-3 小時 新手友好度 68/100
modrinth/code#8256 · 1 個 reaction ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
website
難度 1/5 1 小時以內 新手友好度 66/100
維護者通常 1 天內回覆
-
Button reorder request可能重新可做 @Ceebug 於 17 天前認領，目前沒有進行中的 PR。 未關閉
難度 1/5 1-3 小時 新手友好度 70/100
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 65/100
pop-os/cosmic-settings#2296 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 70/100
jonathanong/no-mistakes#3431 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 62/100
Eyevinn/open-live-ingest#36 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
superradcompany/microsandbox#2071 ·
維護者通常 1 天內回覆