Inconsistency with new instance SVG icon acceptance
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start at the New instance flow's icon upload control and trace how its file picker filters image types, then compare that with the validation used when creating an instance. The issue also asks for an audit of other Modrinth UI flows, so identify which upload controls share the mismatch. Done means unsupported formats such as SVG cannot be selected where creation rejects them, with the picker and validation criteria aligned.
由索引模型根据 Issue 内容生成。
描述
Please confirm the following.
- I checked the existing issues for duplicate problems
- I have tried resolving the issue using the support portal
- I have ensured my Modrinth App installation is up to date
What version of the Modrinth App are you using?
0.22.0
What operating systems are you seeing the problem on?
MacOS
Describe the bug
When creating a new instance with a custom setup, SVG files are accepted via the Upload button for the instance icon, and render properly within the modal. However, when the Create instance button is selected, an error toast appears reading "An error occurred / invalid input: SVG instance icons are not supported", and instance creation fails. The initial acceptance of SVGs in the icon upload flow is misleading, and should be rejected so that progress isn't unexpectedly lost when creating an instance.
Steps to reproduce
- Go to the Home tab
- Under Library, select the New instance button
- Choose the Custom setup instance type
- Select the Upload button, and upload an SVG file
- Select the Create instance button
- See the error toast appear
Expected behavior
SVG files are unselectable in the Upload instance icon file picker.
Additional context
- This issue is likely present on all OS versions, and may be present in other Modrinth UI (e.g. web) where instance icons are accepted. These should be audited too to make sure behavior is consistent, especially for more-impactful situations like mod release flows to prevent even more lost progress.
- The criteria for all accepted file types in the Upload icon file picker should be synchronized with the actual accepted file types to keep these behaviors consistent. For example, it's possible the file picker accepts all image types including SVG and HEIC, whereas actual instance creation may only work with more standard file types like PNG and JPG. I haven't checked any actual code implementation for these claims.
- 主要语言
- Rust
- 星标
- 2.5k
- 派生
- 663
- 平均合并
- 2 天 11 小时
- 30 天内合并 PR
- 122
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
modrinth/code 的其他 Issue
-
app
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
website
难度 2/5 1-3 小时 新手友好度 68/100
modrinth/code#8256 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
website
难度 1/5 1 小时以内 新手友好度 66/100
维护者通常 1 天内回复
-
Button reorder request可能重新可做 @Ceebug 于 17 天前认领，目前没有进行中的 PR。 未关闭
难度 1/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
相似的 Issue
-
bug bug jury peripheral:i2s
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
ライブラリを追加未关闭priority middle
难度 1/5 1 小时以内 新手友好度 62/100
KATO-Hiro/AtCoderClans#13015 ·
维护者通常 1 天内回复
-
needs-review
难度 2/5 1-3 小时 新手友好度 70/100
UCS-Care-Group/mailcraft#1429 ·
维护者通常 1 天内回复
-
priority: medium ready
难度 1/5 1 小时以内 新手友好度 88/100
TusanHomichi/PSIV#646 ·
维护者通常 1 天内回复