Inconsistency with new instance SVG icon acceptance

Aperta
  • Qualcosa non va?
#8,131 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
frontend

Direzione di ricerca

Start at the New instance flow's icon upload control and trace how its file picker filters image types, then compare that with the validation used when creating an instance. The issue also asks for an audit of other Modrinth UI flows, so identify which upload controls share the mismatch. Done means unsupported formats such as SVG cannot be selected where creation rejects them, with the picker and validation criteria aligned.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

app
Please confirm the following.
  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date
What version of the Modrinth App are you using?

0.22.0

What operating systems are you seeing the problem on?

MacOS

Describe the bug

When creating a new instance with a custom setup, SVG files are accepted via the Upload button for the instance icon, and render properly within the modal. However, when the Create instance button is selected, an error toast appears reading "An error occurred / invalid input: SVG instance icons are not supported", and instance creation fails. The initial acceptance of SVGs in the icon upload flow is misleading, and should be rejected so that progress isn't unexpectedly lost when creating an instance.

Steps to reproduce
  1. Go to the Home tab
  2. Under Library, select the New instance button
  3. Choose the Custom setup instance type
  4. Select the Upload button, and upload an SVG file
  5. Select the Create instance button
  6. See the error toast appear
Expected behavior

SVG files are unselectable in the Upload instance icon file picker.

Additional context
  • This issue is likely present on all OS versions, and may be present in other Modrinth UI (e.g. web) where instance icons are accepted. These should be audited too to make sure behavior is consistent, especially for more-impactful situations like mod release flows to prevent even more lost progress.
  • The criteria for all accepted file types in the Upload icon file picker should be synchronized with the actual accepted file types to keep these behaviors consistent. For example, it's possible the file picker accepts all image types including SVG and HEIC, whereas actual instance creation may only work with more standard file types like PNG and JPG. I haven't checked any actual code implementation for these claims.
Lingua principale
Rust
Stelle
2.5k
Fork
663
Merge medio
2g 11h
PR unite (30g)
122

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di modrinth/code

Tutte le issue di modrinth/code

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.