Inconsistency with new instance SVG icon acceptance

Aberta
  • Algo errado?
#8,131 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
58/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
frontend

Direção de pesquisa

Start at the New instance flow's icon upload control and trace how its file picker filters image types, then compare that with the validation used when creating an instance. The issue also asks for an audit of other Modrinth UI flows, so identify which upload controls share the mismatch. Done means unsupported formats such as SVG cannot be selected where creation rejects them, with the picker and validation criteria aligned.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

app
Please confirm the following.
  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date
What version of the Modrinth App are you using?

0.22.0

What operating systems are you seeing the problem on?

MacOS

Describe the bug

When creating a new instance with a custom setup, SVG files are accepted via the Upload button for the instance icon, and render properly within the modal. However, when the Create instance button is selected, an error toast appears reading "An error occurred / invalid input: SVG instance icons are not supported", and instance creation fails. The initial acceptance of SVGs in the icon upload flow is misleading, and should be rejected so that progress isn't unexpectedly lost when creating an instance.

Steps to reproduce
  1. Go to the Home tab
  2. Under Library, select the New instance button
  3. Choose the Custom setup instance type
  4. Select the Upload button, and upload an SVG file
  5. Select the Create instance button
  6. See the error toast appear
Expected behavior

SVG files are unselectable in the Upload instance icon file picker.

Additional context
  • This issue is likely present on all OS versions, and may be present in other Modrinth UI (e.g. web) where instance icons are accepted. These should be audited too to make sure behavior is consistent, especially for more-impactful situations like mod release flows to prevent even more lost progress.
  • The criteria for all accepted file types in the Upload icon file picker should be synchronized with the actual accepted file types to keep these behaviors consistent. For example, it's possible the file picker accepts all image types including SVG and HEIC, whereas actual instance creation may only work with more standard file types like PNG and JPG. I haven't checked any actual code implementation for these claims.
Linguagem predominante
Rust
Estrelas
2.5k
Forks
663
Merge médio
2d 11h
PRs com merge (30d)
122

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de modrinth/code

Todas as issues de modrinth/code

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.