Inconsistency with new instance SVG icon acceptance

Abierto
  • ¿Algo no está bien?
#8,131 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
58/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
frontend

Línea de trabajo

Start at the New instance flow's icon upload control and trace how its file picker filters image types, then compare that with the validation used when creating an instance. The issue also asks for an audit of other Modrinth UI flows, so identify which upload controls share the mismatch. Done means unsupported formats such as SVG cannot be selected where creation rejects them, with the picker and validation criteria aligned.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

app
Please confirm the following.
  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date
What version of the Modrinth App are you using?

0.22.0

What operating systems are you seeing the problem on?

MacOS

Describe the bug

When creating a new instance with a custom setup, SVG files are accepted via the Upload button for the instance icon, and render properly within the modal. However, when the Create instance button is selected, an error toast appears reading "An error occurred / invalid input: SVG instance icons are not supported", and instance creation fails. The initial acceptance of SVGs in the icon upload flow is misleading, and should be rejected so that progress isn't unexpectedly lost when creating an instance.

Steps to reproduce
  1. Go to the Home tab
  2. Under Library, select the New instance button
  3. Choose the Custom setup instance type
  4. Select the Upload button, and upload an SVG file
  5. Select the Create instance button
  6. See the error toast appear
Expected behavior

SVG files are unselectable in the Upload instance icon file picker.

Additional context
  • This issue is likely present on all OS versions, and may be present in other Modrinth UI (e.g. web) where instance icons are accepted. These should be audited too to make sure behavior is consistent, especially for more-impactful situations like mod release flows to prevent even more lost progress.
  • The criteria for all accepted file types in the Upload icon file picker should be synchronized with the actual accepted file types to keep these behaviors consistent. For example, it's possible the file picker accepts all image types including SVG and HEIC, whereas actual instance creation may only work with more standard file types like PNG and JPG. I haven't checked any actual code implementation for these claims.
Lenguaje dominante
Rust
Estrellas
2.5k
Forks
663
Merge medio
2 d 11 h
PR fusionados (30 d)
122

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de modrinth/code

Todos los issues de modrinth/code

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.