Let the player choose the promotion piece
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 55/100
- Issue 類型
- 功能
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- javascript
研究方向
Read js/game.js:221-228 and js/promotion.js:153-185 to trace how moves and the existing dialog work; check index.html:65-71 and js/config.js:14 for loading and configuration. Run npm test and npm run lint to establish the baseline. Done when players can choose all four pieces, keyboard users can operate the dialog, notation records the choice, and undo restores the pawn.
由索引模型根據 Issue 內容生成。
描述
Summary
A pawn reaching the last rank always becomes a queen with no prompt, so underpromotion is impossible. A promotion dialog already exists in js/promotion.js but is never loaded or called.
Where
js/game.js:221-228(auto-queen,// TODO: Implement choice?)js/promotion.js:153-185(showPromotionModalreturns a Promise),js/promotion.js:57-64(options are click-onlydivs)index.html:65-71(script not loaded),js/config.js:14(PROMOTION_UI: false)
Proposal
Load promotion.js. When a pawn reaches the last rank, hold the move, show the dialog, then finish the move (notation, check detection, save) with the chosen piece. Block board input while the dialog is open. Make the options real <button> elements with labels so keyboard users can promote.
Open question: makeMove is synchronous and tests call it directly. An optional promotionType parameter, defaulting to queen, keeps tests and a future AI simple. See #31.
Who benefits
Every player whose game reaches promotion; knight promotions and rook or bishop promotions that avoid stalemate become possible.
Acceptance criteria
- The player can choose queen, rook, bishop or knight
- Notation shows the chosen piece (
e8=N) - The dialog is usable by keyboard
- Undo after a promotion restores the pawn
Getting started
- Relevant files:
js/game.js,js/promotion.js,index.html,js/config.js - How to run tests:
npm install, thennpm testandnpm run lint - Related docs:
docs/ARCHITECTURE.md,.github/CONTRIBUTING.md
Filed by repo-audit/full-audit at 8a2c86c. Severity: high. Effort: M. audit-key: enhancement|js/game.js|makeMove.promotion
- 主要語言
- JavaScript
- 星號
- 4
- 分支
- 2
- PR 合併指標
- 30 天內沒有已合併 PR
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
TMHSDigital/Static_Chess 的其他 Issue
-
enhancement good first issue severity: medium
難度 2/5 1-3 小時 新手友好度 78/100
TMHSDigital/Static_Chess#53 ·
-
documentation good first issue severity: low
難度 2/5 1-3 小時 新手友好度 72/100
TMHSDigital/Static_Chess#49 ·
-
documentation good first issue severity: low
難度 2/5 1-3 小時 新手友好度 83/100
TMHSDigital/Static_Chess#48 ·
-
documentation severity: medium
難度 2/5 1-3 小時 新手友好度 78/100
TMHSDigital/Static_Chess#47 ·
-
documentation good first issue severity: low
難度 2/5 1-3 小時 新手友好度 82/100
TMHSDigital/Static_Chess#46 ·
查看 TMHSDigital/Static_Chess 的全部 Issue
相似的 Issue
-
good first issue tests
難度 1/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
enhancement good first issue
難度 2/5 1-3 小時 新手友好度 90/100
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
難度 2/5 1-3 小時 新手友好度 65/100
growilabs/growi#12246 · 3 則留言 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 72/100
TMHSDigital/Free-Game-Dev-Assets#301 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 79/100