Let the player choose the promotion piece

Abierto
  • ¿Algo no está bien?
#51 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript
Área
accessibility, frontend

Línea de trabajo

Read js/game.js:221-228 and js/promotion.js:153-185 to trace how moves and the existing dialog work; check index.html:65-71 and js/config.js:14 for loading and configuration. Run npm test and npm run lint to establish the baseline. Done when players can choose all four pieces, keyboard users can operate the dialog, notation records the choice, and undo restores the pawn.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement severity: high

Summary

A pawn reaching the last rank always becomes a queen with no prompt, so underpromotion is impossible. A promotion dialog already exists in js/promotion.js but is never loaded or called.

Where

  • js/game.js:221-228 (auto-queen, // TODO: Implement choice?)
  • js/promotion.js:153-185 (showPromotionModal returns a Promise), js/promotion.js:57-64 (options are click-only divs)
  • index.html:65-71 (script not loaded), js/config.js:14 (PROMOTION_UI: false)

Proposal

Load promotion.js. When a pawn reaches the last rank, hold the move, show the dialog, then finish the move (notation, check detection, save) with the chosen piece. Block board input while the dialog is open. Make the options real <button> elements with labels so keyboard users can promote.

Open question: makeMove is synchronous and tests call it directly. An optional promotionType parameter, defaulting to queen, keeps tests and a future AI simple. See #31.

Who benefits

Every player whose game reaches promotion; knight promotions and rook or bishop promotions that avoid stalemate become possible.

Acceptance criteria

  • The player can choose queen, rook, bishop or knight
  • Notation shows the chosen piece (e8=N)
  • The dialog is usable by keyboard
  • Undo after a promotion restores the pawn

Getting started

  • Relevant files: js/game.js, js/promotion.js, index.html, js/config.js
  • How to run tests: npm install, then npm test and npm run lint
  • Related docs: docs/ARCHITECTURE.md, .github/CONTRIBUTING.md

Filed by repo-audit/full-audit at 8a2c86c. Severity: high. Effort: M. audit-key: enhancement|js/game.js|makeMove.promotion

Lenguaje dominante
JavaScript
Estrellas
4
Forks
2
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/Static_Chess

Todos los issues de TMHSDigital/Static_Chess

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.