Let the player choose the promotion piece

Offen
  • Stimmt etwas nicht?
#51 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
javascript
Bereich
accessibility, frontend

Rechercherichtung

Read js/game.js:221-228 and js/promotion.js:153-185 to trace how moves and the existing dialog work; check index.html:65-71 and js/config.js:14 for loading and configuration. Run npm test and npm run lint to establish the baseline. Done when players can choose all four pieces, keyboard users can operate the dialog, notation records the choice, and undo restores the pawn.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement severity: high

Summary

A pawn reaching the last rank always becomes a queen with no prompt, so underpromotion is impossible. A promotion dialog already exists in js/promotion.js but is never loaded or called.

Where

  • js/game.js:221-228 (auto-queen, // TODO: Implement choice?)
  • js/promotion.js:153-185 (showPromotionModal returns a Promise), js/promotion.js:57-64 (options are click-only divs)
  • index.html:65-71 (script not loaded), js/config.js:14 (PROMOTION_UI: false)

Proposal

Load promotion.js. When a pawn reaches the last rank, hold the move, show the dialog, then finish the move (notation, check detection, save) with the chosen piece. Block board input while the dialog is open. Make the options real <button> elements with labels so keyboard users can promote.

Open question: makeMove is synchronous and tests call it directly. An optional promotionType parameter, defaulting to queen, keeps tests and a future AI simple. See #31.

Who benefits

Every player whose game reaches promotion; knight promotions and rook or bishop promotions that avoid stalemate become possible.

Acceptance criteria

  • The player can choose queen, rook, bishop or knight
  • Notation shows the chosen piece (e8=N)
  • The dialog is usable by keyboard
  • Undo after a promotion restores the pawn

Getting started

  • Relevant files: js/game.js, js/promotion.js, index.html, js/config.js
  • How to run tests: npm install, then npm test and npm run lint
  • Related docs: docs/ARCHITECTURE.md, .github/CONTRIBUTING.md

Filed by repo-audit/full-audit at 8a2c86c. Severity: high. Effort: M. audit-key: enhancement|js/game.js|makeMove.promotion

Vorherrschende Sprache
JavaScript
Sterne
4
Forks
2
Keine gemergten PRs in 30 T.

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/Static_Chess

Alle Issues in TMHSDigital/Static_Chess

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.