memory: hand-off test "does not let a writer that created the lock while a live one was aside run beside its holder" fails intermittently on Windows since #5623
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- node.js, typescript
Research direction
Start with file-lock.test.ts and the withFileLock hand-off test named in the issue, then trace the lock handling in src/memory/index.ts, especially the Windows rename and EPERM pending-delete path. Reproduce the intermittent failure on Windows and determine whether the timing assumption is in the test or the hand-off logic. Done means the test passes deterministically without retries, and the hand-off window is closed if the cause is in index.ts.
Written by the indexing model from the issue text.
Description
Problem
Since #5623 (the fix for #5565) merged into v2/main as 13725688, Test memory (Windows) fails intermittently on one of the tests it added:
file-lock.test.ts > withFileLock > hand-off windows (#5565) > does not let a writer that created the lock while a live one was aside run beside its holder
AssertionError: promise resolved "'breaker ran'" instead of rejecting
Seen three times in the first eight Windows runs after the merge, each on a change that does not touch src/memory/ code:
v2/mainpush at 77d1bf3f (job 135207834310)v2/mainpush at 640a8c31 (job 135217697055)- PR #5629 at 9db3591f (job 135219828145)
The same test passed on #5623's own Windows legs before it merged, and on Linux and macOS it has not failed.
Why it matters
The assertion is the one the fix exists for: the breaker took a successor's live lock aside, a third writer created its own lock in the gap, and the breaker then ran its operation instead of timing out. That is either a timing assumption in the test that does not hold on Windows, or the hand-off window #5565 meant to close still opening on Windows (for example around the rename that restores the lock, or the Windows EPERM pending-delete path). Which one is not yet established.
Every PR runs every server's tests, so until this is resolved about one Windows run in three goes red for reasons unrelated to the PR.
Expected
The test passes deterministically on Windows, with no retry, and if the cause is in index.ts rather than the test, the hand-off window is closed there as well.
- Dominant language
- TypeScript
- Stars
- 92k
- Forks
- 12k
- Avg merge
- 3h 46m
- Merged PRs (30d)
- 206
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/servers
-
`interface-diff` discards the git error when resolving its default base and reports the wrong causeOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
modelcontextprotocol/servers#5636 ·
Maintainers usually reply within 1 day
-
chore server-memory v2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
modelcontextprotocol/servers#5634 ·
Maintainers usually reply within 1 day
-
documentation server-memory v2
Difficulty 1/5 Under an hour Newbie friendliness 90/100
modelcontextprotocol/servers#5609 · 1 comment ·
Maintainers usually reply within 1 day
-
bug server-memory v2
Difficulty 5/5 Over a week Newbie friendliness 42/100
modelcontextprotocol/servers#5624 ·
Maintainers usually reply within 1 day
-
enhancement v2
Difficulty 4/5 3-5 days Newbie friendliness 48/100
modelcontextprotocol/servers#5611 ·
Maintainers usually reply within 1 day
All issues in modelcontextprotocol/servers
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
hurttlocker/o8#6535 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
area: backend bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
snapotter-hq/SnapOtter#4856 ·
Maintainers usually reply within 1 day
-
bug follow-up
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
spellshift/realm#2509 ·
Maintainers usually reply within 1 day