memory: hand-off test "does not let a writer that created the lock while a live one was aside run beside its holder" fails intermittently on Windows since #5623
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 48/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- node.js, typescript
研究方向
Start with file-lock.test.ts and the withFileLock hand-off test named in the issue, then trace the lock handling in src/memory/index.ts, especially the Windows rename and EPERM pending-delete path. Reproduce the intermittent failure on Windows and determine whether the timing assumption is in the test or the hand-off logic. Done means the test passes deterministically without retries, and the hand-off window is closed if the cause is in index.ts.
由索引模型根據 Issue 內容生成。
描述
Problem
Since #5623 (the fix for #5565) merged into v2/main as 13725688, Test memory (Windows) fails intermittently on one of the tests it added:
file-lock.test.ts > withFileLock > hand-off windows (#5565) > does not let a writer that created the lock while a live one was aside run beside its holder
AssertionError: promise resolved "'breaker ran'" instead of rejecting
Seen three times in the first eight Windows runs after the merge, each on a change that does not touch src/memory/ code:
v2/mainpush at 77d1bf3f (job 135207834310)v2/mainpush at 640a8c31 (job 135217697055)- PR #5629 at 9db3591f (job 135219828145)
The same test passed on #5623's own Windows legs before it merged, and on Linux and macOS it has not failed.
Why it matters
The assertion is the one the fix exists for: the breaker took a successor's live lock aside, a third writer created its own lock in the gap, and the breaker then ran its operation instead of timing out. That is either a timing assumption in the test that does not hold on Windows, or the hand-off window #5565 meant to close still opening on Windows (for example around the rename that restores the lock, or the Windows EPERM pending-delete path). Which one is not yet established.
Every PR runs every server's tests, so until this is resolved about one Windows run in three goes red for reasons unrelated to the PR.
Expected
The test passes deterministically on Windows, with no retry, and if the cause is in index.ts rather than the test, the hand-off window is closed there as well.
- 主要語言
- TypeScript
- 星號
- 92k
- 分支
- 12k
- 平均合併
- 3 小時 46 分鐘
- 30 天內合併 PR
- 206
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
modelcontextprotocol/servers 的其他 Issue
-
`interface-diff` discards the git error when resolving its default base and reports the wrong cause未關閉
難度 2/5 1-3 小時 新手友好度 82/100
modelcontextprotocol/servers#5636 ·
維護者通常 1 天內回覆
-
chore server-memory v2
難度 2/5 1-3 小時 新手友好度 76/100
modelcontextprotocol/servers#5634 ·
維護者通常 1 天內回覆
-
documentation server-memory v2
難度 1/5 1 小時以內 新手友好度 90/100
modelcontextprotocol/servers#5609 · 1 則留言 ·
維護者通常 1 天內回覆
-
bug server-memory v2
難度 5/5 一週以上 新手友好度 42/100
modelcontextprotocol/servers#5624 ·
維護者通常 1 天內回覆
-
enhancement v2
難度 4/5 3-5 天 新手友好度 48/100
modelcontextprotocol/servers#5611 ·
維護者通常 1 天內回覆
查看 modelcontextprotocol/servers 的全部 Issue
相似的 Issue
-
bug impact:low Team: SecuritySolution Team:Defend Workflows v9.6.0
難度 2/5 1-3 小時 新手友好度 72/100
elastic/kibana#306401 · 3 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
agentes-chat/agentes-chat#927 ·
維護者通常 1 天內回覆
-
comp/desktop P2 type/bug
難度 2/5 1-3 小時 新手友好度 78/100
NousResearch/hermes-agent#157702 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
e2e-failure ready-to-code
難度 1/5 1 小時以內 新手友好度 72/100
redhat-developer/rhdh-plugin-export-overlays#4794 · 1 則留言 ·
維護者通常 1 天內回覆