memory: hand-off test "does not let a writer that created the lock while a live one was aside run beside its holder" fails intermittently on Windows since #5623
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
调研方向
Start with file-lock.test.ts and the withFileLock hand-off test named in the issue, then trace the lock handling in src/memory/index.ts, especially the Windows rename and EPERM pending-delete path. Reproduce the intermittent failure on Windows and determine whether the timing assumption is in the test or the hand-off logic. Done means the test passes deterministically without retries, and the hand-off window is closed if the cause is in index.ts.
由索引模型根据 Issue 内容生成。
描述
Problem
Since #5623 (the fix for #5565) merged into v2/main as 13725688, Test memory (Windows) fails intermittently on one of the tests it added:
file-lock.test.ts > withFileLock > hand-off windows (#5565) > does not let a writer that created the lock while a live one was aside run beside its holder
AssertionError: promise resolved "'breaker ran'" instead of rejecting
Seen three times in the first eight Windows runs after the merge, each on a change that does not touch src/memory/ code:
v2/mainpush at 77d1bf3f (job 135207834310)v2/mainpush at 640a8c31 (job 135217697055)- PR #5629 at 9db3591f (job 135219828145)
The same test passed on #5623's own Windows legs before it merged, and on Linux and macOS it has not failed.
Why it matters
The assertion is the one the fix exists for: the breaker took a successor's live lock aside, a third writer created its own lock in the gap, and the breaker then ran its operation instead of timing out. That is either a timing assumption in the test that does not hold on Windows, or the hand-off window #5565 meant to close still opening on Windows (for example around the rename that restores the lock, or the Windows EPERM pending-delete path). Which one is not yet established.
Every PR runs every server's tests, so until this is resolved about one Windows run in three goes red for reasons unrelated to the PR.
Expected
The test passes deterministically on Windows, with no retry, and if the cause is in index.ts rather than the test, the hand-off window is closed there as well.
- 主要语言
- TypeScript
- 星标
- 92k
- 派生
- 12k
- 平均合并
- 3 小时 46 分钟
- 30 天内合并 PR
- 206
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
modelcontextprotocol/servers 的其他 Issue
-
`interface-diff` discards the git error when resolving its default base and reports the wrong cause未关闭
难度 2/5 1-3 小时 新手友好度 82/100
modelcontextprotocol/servers#5636 ·
维护者通常 1 天内回复
-
chore server-memory v2
难度 2/5 1-3 小时 新手友好度 76/100
modelcontextprotocol/servers#5634 ·
维护者通常 1 天内回复
-
documentation server-memory v2
难度 1/5 1 小时以内 新手友好度 90/100
modelcontextprotocol/servers#5609 · 1 条评论 ·
维护者通常 1 天内回复
-
bug server-memory v2
难度 5/5 一周以上 新手友好度 42/100
modelcontextprotocol/servers#5624 ·
维护者通常 1 天内回复
-
enhancement v2
难度 4/5 3-5 天 新手友好度 48/100
modelcontextprotocol/servers#5611 ·
维护者通常 1 天内回复
查看 modelcontextprotocol/servers 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 79/100
hurttlocker/o8#6535 ·
-
难度 2/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复
-
area: backend bug priority: low
难度 2/5 1-3 小时 新手友好度 92/100
snapotter-hq/SnapOtter#4856 ·
维护者通常 1 天内回复
-
bug follow-up
难度 1/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
spellshift/realm#2509 ·
维护者通常 1 天内回复