memory: hand-off test "does not let a writer that created the lock while a live one was aside run beside its holder" fails intermittently on Windows since #5623

オープン
#5,635 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
node.js, typescript
領域
backend, testing

調査の方向性

Start with file-lock.test.ts and the withFileLock hand-off test named in the issue, then trace the lock handling in src/memory/index.ts, especially the Windows rename and EPERM pending-delete path. Reproduce the intermittent failure on Windows and determine whether the timing assumption is in the test or the hand-off logic. Done means the test passes deterministically without retries, and the hand-off window is closed if the cause is in index.ts.

索引モデルが issue の本文から書いたものです。

説明

bug server-memory v2

Problem

Since #5623 (the fix for #5565) merged into v2/main as 13725688, Test memory (Windows) fails intermittently on one of the tests it added:

file-lock.test.ts > withFileLock > hand-off windows (#5565) > does not let a writer that created the lock while a live one was aside run beside its holder

AssertionError: promise resolved "'breaker ran'" instead of rejecting

Seen three times in the first eight Windows runs after the merge, each on a change that does not touch src/memory/ code:

  • v2/main push at 77d1bf3f (job 135207834310)
  • v2/main push at 640a8c31 (job 135217697055)
  • PR #5629 at 9db3591f (job 135219828145)

The same test passed on #5623's own Windows legs before it merged, and on Linux and macOS it has not failed.

Why it matters

The assertion is the one the fix exists for: the breaker took a successor's live lock aside, a third writer created its own lock in the gap, and the breaker then ran its operation instead of timing out. That is either a timing assumption in the test that does not hold on Windows, or the hand-off window #5565 meant to close still opening on Windows (for example around the rename that restores the lock, or the Windows EPERM pending-delete path). Which one is not yet established.

Every PR runs every server's tests, so until this is resolved about one Windows run in three goes red for reasons unrelated to the PR.

Expected

The test passes deterministically on Windows, with no retry, and if the cause is in index.ts rather than the test, the hand-off window is closed there as well.

主要言語
TypeScript
スター
92k
フォーク
12k
平均マージ
3時間 46分
マージ済み PR(30日)
206

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

modelcontextprotocol/servers のほかの issue

modelcontextprotocol/servers の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。