memory: hand-off test "does not let a writer that created the lock while a live one was aside run beside its holder" fails intermittently on Windows since #5623

Aperta
#5,635 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
node.js, typescript
Ambito
backend, testing

Direzione di ricerca

Start with file-lock.test.ts and the withFileLock hand-off test named in the issue, then trace the lock handling in src/memory/index.ts, especially the Windows rename and EPERM pending-delete path. Reproduce the intermittent failure on Windows and determine whether the timing assumption is in the test or the hand-off logic. Done means the test passes deterministically without retries, and the hand-off window is closed if the cause is in index.ts.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug server-memory v2

Problem

Since #5623 (the fix for #5565) merged into v2/main as 13725688, Test memory (Windows) fails intermittently on one of the tests it added:

file-lock.test.ts > withFileLock > hand-off windows (#5565) > does not let a writer that created the lock while a live one was aside run beside its holder

AssertionError: promise resolved "'breaker ran'" instead of rejecting

Seen three times in the first eight Windows runs after the merge, each on a change that does not touch src/memory/ code:

  • v2/main push at 77d1bf3f (job 135207834310)
  • v2/main push at 640a8c31 (job 135217697055)
  • PR #5629 at 9db3591f (job 135219828145)

The same test passed on #5623's own Windows legs before it merged, and on Linux and macOS it has not failed.

Why it matters

The assertion is the one the fix exists for: the breaker took a successor's live lock aside, a third writer created its own lock in the gap, and the breaker then ran its operation instead of timing out. That is either a timing assumption in the test that does not hold on Windows, or the hand-off window #5565 meant to close still opening on Windows (for example around the rename that restores the lock, or the Windows EPERM pending-delete path). Which one is not yet established.

Every PR runs every server's tests, so until this is resolved about one Windows run in three goes red for reasons unrelated to the PR.

Expected

The test passes deterministically on Windows, with no retry, and if the cause is in index.ts rather than the test, the hand-off window is closed there as well.

Lingua principale
TypeScript
Stelle
92k
Fork
12k
Merge medio
3h 46m
PR unite (30g)
206

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di modelcontextprotocol/servers

Tutte le issue di modelcontextprotocol/servers

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.