memory: hand-off test "does not let a writer that created the lock while a live one was aside run beside its holder" fails intermittently on Windows since #5623
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- node.js, typescript
Línea de trabajo
Start with file-lock.test.ts and the withFileLock hand-off test named in the issue, then trace the lock handling in src/memory/index.ts, especially the Windows rename and EPERM pending-delete path. Reproduce the intermittent failure on Windows and determine whether the timing assumption is in the test or the hand-off logic. Done means the test passes deterministically without retries, and the hand-off window is closed if the cause is in index.ts.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
Since #5623 (the fix for #5565) merged into v2/main as 13725688, Test memory (Windows) fails intermittently on one of the tests it added:
file-lock.test.ts > withFileLock > hand-off windows (#5565) > does not let a writer that created the lock while a live one was aside run beside its holder
AssertionError: promise resolved "'breaker ran'" instead of rejecting
Seen three times in the first eight Windows runs after the merge, each on a change that does not touch src/memory/ code:
v2/mainpush at 77d1bf3f (job 135207834310)v2/mainpush at 640a8c31 (job 135217697055)- PR #5629 at 9db3591f (job 135219828145)
The same test passed on #5623's own Windows legs before it merged, and on Linux and macOS it has not failed.
Why it matters
The assertion is the one the fix exists for: the breaker took a successor's live lock aside, a third writer created its own lock in the gap, and the breaker then ran its operation instead of timing out. That is either a timing assumption in the test that does not hold on Windows, or the hand-off window #5565 meant to close still opening on Windows (for example around the rename that restores the lock, or the Windows EPERM pending-delete path). Which one is not yet established.
Every PR runs every server's tests, so until this is resolved about one Windows run in three goes red for reasons unrelated to the PR.
Expected
The test passes deterministically on Windows, with no retry, and if the cause is in index.ts rather than the test, the hand-off window is closed there as well.
- Lenguaje dominante
- TypeScript
- Estrellas
- 92k
- Forks
- 12k
- Merge medio
- 3 h 46 min
- PR fusionados (30 d)
- 206
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de modelcontextprotocol/servers
-
`interface-diff` discards the git error when resolving its default base and reports the wrong causeAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
modelcontextprotocol/servers#5636 ·
Los mantenedores suelen responder en 1 día
-
chore server-memory v2
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
modelcontextprotocol/servers#5634 ·
Los mantenedores suelen responder en 1 día
-
documentation server-memory v2
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
modelcontextprotocol/servers#5609 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
bug server-memory v2
Dificultad 5/5 Más de una semana Aptitud para principiantes 42/100
modelcontextprotocol/servers#5624 ·
Los mantenedores suelen responder en 1 día
-
enhancement v2
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
modelcontextprotocol/servers#5611 ·
Los mantenedores suelen responder en 1 día
Todos los issues de modelcontextprotocol/servers
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 79/100
hurttlocker/o8#6535 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día
-
area: backend bug priority: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 92/100
snapotter-hq/SnapOtter#4856 ·
Los mantenedores suelen responder en 1 día
-
bug follow-up
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
spellshift/realm#2509 ·
Los mantenedores suelen responder en 1 día