Add Radiance as a Shader Loader

オープン
  • 何か問題がありますか？
#8,166 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
rust
領域
backend, full-stack

調査の方向性

Start by locating the shader loader list, the upload validation that checks shader pack ZIP contents, and the Modrinth App logic that chooses the install folder; the issue does not name files or tests. Trace how Iris packs are validated and installed, then determine how Radiance should be represented across those entry points. Done means Radiance is selectable, ZIPs with a root configs.json are accepted, and the App installs packs to shaderpacks.

索引モデルが issue の本文から書いたものです。

説明

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App, Modrinth.com website

Is your suggested feature related to a problem? Please describe.

Radiance has its own shader pack format, which isn't compatible with OptiFine, Iris, Canvas or vanilla shaders. I'm trying to publish one, but the version upload requires one of those four loaders, and each one checks the zip for its own files (a shaders/ folder or a pack.mcmeta). A Radiance pack has neither, so I can't upload it without tagging it with a loader it doesn't work with, which would mislead Iris and OptiFine users.

Radiance is a Vulkan ray-tracing renderer for Minecraft (NeoForge and Fabric), already published on Modrinth:

Source: https://github.com/Minecraft-Radiance/Radiance

Describe the solution you'd like

A new shader loader: Radiance. It would need:

  1. "Radiance" added to the shader loaders list.
  2. The upload check accepting a zip with configs.json at the root.
  3. The Modrinth App installing it into shaderpacks, like Iris packs.
Describe alternatives you've considered
  • Tagging the pack as Iris or OptiFine and adding an empty shaders/ folder: it would pass the check and install into the right folder, but Iris and OptiFine users would download a pack that does nothing for them.
  • Tagging it as Vanilla Shader and adding a pack.mcmeta: same problem, and the Modrinth App would likely install it into resourcepacks, where Radiance doesn't look.
  • Hosting the pack outside Modrinth (GitHub Releases): works, but it can't be installed through the Modrinth App or added to Modrinth modpacks.
Additional context

How Radiance packs work, in case it helps:

  • Installed into the same "shaderpacks" folder as Iris and OptiFine packs.
  • A .zip (or folder) with a configs.json at the root, which contains a "radiance" entry with "shader_pack": true.
  • The shaders themselves are Vulkan GLSL (ray generation, hit and compute shaders), compiled by Radiance at runtime.

There are already some Radiance packs (Radiance ships its own built-in ones), so I don't think I'll be the only one. Thanks for considering it!

Image
主要言語
Rust
スター
2.5k
フォーク
663
平均マージ
2日 11時間
マージ済み PR（30日）
122

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

modrinth/code のほかの issue

modrinth/code の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。