Add Radiance as a Shader Loader

Ouverte
  • Quelque chose ne va pas ?
#8,166 0 commentaires 1 réaction 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
rust
Domaine
backend, full-stack

Piste de recherche

Start by locating the shader loader list, the upload validation that checks shader pack ZIP contents, and the Modrinth App logic that chooses the install folder; the issue does not name files or tests. Trace how Iris packs are validated and installed, then determine how Radiance should be represented across those entry points. Done means Radiance is selectable, ZIPs with a root configs.json are accepted, and the App installs packs to shaderpacks.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App, Modrinth.com website

Is your suggested feature related to a problem? Please describe.

Radiance has its own shader pack format, which isn't compatible with OptiFine, Iris, Canvas or vanilla shaders. I'm trying to publish one, but the version upload requires one of those four loaders, and each one checks the zip for its own files (a shaders/ folder or a pack.mcmeta). A Radiance pack has neither, so I can't upload it without tagging it with a loader it doesn't work with, which would mislead Iris and OptiFine users.

Radiance is a Vulkan ray-tracing renderer for Minecraft (NeoForge and Fabric), already published on Modrinth:

Source: https://github.com/Minecraft-Radiance/Radiance

Describe the solution you'd like

A new shader loader: Radiance. It would need:

  1. "Radiance" added to the shader loaders list.
  2. The upload check accepting a zip with configs.json at the root.
  3. The Modrinth App installing it into shaderpacks, like Iris packs.
Describe alternatives you've considered
  • Tagging the pack as Iris or OptiFine and adding an empty shaders/ folder: it would pass the check and install into the right folder, but Iris and OptiFine users would download a pack that does nothing for them.
  • Tagging it as Vanilla Shader and adding a pack.mcmeta: same problem, and the Modrinth App would likely install it into resourcepacks, where Radiance doesn't look.
  • Hosting the pack outside Modrinth (GitHub Releases): works, but it can't be installed through the Modrinth App or added to Modrinth modpacks.
Additional context

How Radiance packs work, in case it helps:

  • Installed into the same "shaderpacks" folder as Iris and OptiFine packs.
  • A .zip (or folder) with a configs.json at the root, which contains a "radiance" entry with "shader_pack": true.
  • The shaders themselves are Vulkan GLSL (ray generation, hit and compute shaders), compiled by Radiance at runtime.

There are already some Radiance packs (Radiance ships its own built-in ones), so I don't think I'll be the only one. Thanks for considering it!

Image
Langage dominant
Rust
Étoiles
2.5k
Forks
663
Merge moyen
2 j 11 h
PR mergées (30 j)
122

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de modrinth/code

Toutes les issues de modrinth/code

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.