Add Radiance as a Shader Loader

Aperta
#8,166 0 commenti 1 reazione 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start by locating the shader loader list, the upload validation that checks shader pack ZIP contents, and the Modrinth App logic that chooses the install folder; the issue does not name files or tests. Trace how Iris packs are validated and installed, then determine how Radiance should be represented across those entry points. Done means Radiance is selectable, ZIPs with a root configs.json are accepted, and the App installs packs to shaderpacks.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App, Modrinth.com website

Is your suggested feature related to a problem? Please describe.

Radiance has its own shader pack format, which isn't compatible with OptiFine, Iris, Canvas or vanilla shaders. I'm trying to publish one, but the version upload requires one of those four loaders, and each one checks the zip for its own files (a shaders/ folder or a pack.mcmeta). A Radiance pack has neither, so I can't upload it without tagging it with a loader it doesn't work with, which would mislead Iris and OptiFine users.

Radiance is a Vulkan ray-tracing renderer for Minecraft (NeoForge and Fabric), already published on Modrinth:

Source: https://github.com/Minecraft-Radiance/Radiance

Describe the solution you'd like

A new shader loader: Radiance. It would need:

  1. "Radiance" added to the shader loaders list.
  2. The upload check accepting a zip with configs.json at the root.
  3. The Modrinth App installing it into shaderpacks, like Iris packs.
Describe alternatives you've considered
  • Tagging the pack as Iris or OptiFine and adding an empty shaders/ folder: it would pass the check and install into the right folder, but Iris and OptiFine users would download a pack that does nothing for them.
  • Tagging it as Vanilla Shader and adding a pack.mcmeta: same problem, and the Modrinth App would likely install it into resourcepacks, where Radiance doesn't look.
  • Hosting the pack outside Modrinth (GitHub Releases): works, but it can't be installed through the Modrinth App or added to Modrinth modpacks.
Additional context

How Radiance packs work, in case it helps:

  • Installed into the same "shaderpacks" folder as Iris and OptiFine packs.
  • A .zip (or folder) with a configs.json at the root, which contains a "radiance" entry with "shader_pack": true.
  • The shaders themselves are Vulkan GLSL (ray generation, hit and compute shaders), compiled by Radiance at runtime.

There are already some Radiance packs (Radiance ships its own built-in ones), so I don't think I'll be the only one. Thanks for considering it!

Image
Lingua principale
Rust
Stelle
2.5k
Fork
663
Merge medio
2g 11h
PR unite (30g)
122

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di modrinth/code

Tutte le issue di modrinth/code

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.