Add Radiance as a Shader Loader

Offen
  • Stimmt etwas nicht?
#8,166 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
rust
Bereich
backend, full-stack

Rechercherichtung

Start by locating the shader loader list, the upload validation that checks shader pack ZIP contents, and the Modrinth App logic that chooses the install folder; the issue does not name files or tests. Trace how Iris packs are validated and installed, then determine how Radiance should be represented across those entry points. Done means Radiance is selectable, ZIPs with a root configs.json are accepted, and the App installs packs to shaderpacks.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App, Modrinth.com website

Is your suggested feature related to a problem? Please describe.

Radiance has its own shader pack format, which isn't compatible with OptiFine, Iris, Canvas or vanilla shaders. I'm trying to publish one, but the version upload requires one of those four loaders, and each one checks the zip for its own files (a shaders/ folder or a pack.mcmeta). A Radiance pack has neither, so I can't upload it without tagging it with a loader it doesn't work with, which would mislead Iris and OptiFine users.

Radiance is a Vulkan ray-tracing renderer for Minecraft (NeoForge and Fabric), already published on Modrinth:

Source: https://github.com/Minecraft-Radiance/Radiance

Describe the solution you'd like

A new shader loader: Radiance. It would need:

  1. "Radiance" added to the shader loaders list.
  2. The upload check accepting a zip with configs.json at the root.
  3. The Modrinth App installing it into shaderpacks, like Iris packs.
Describe alternatives you've considered
  • Tagging the pack as Iris or OptiFine and adding an empty shaders/ folder: it would pass the check and install into the right folder, but Iris and OptiFine users would download a pack that does nothing for them.
  • Tagging it as Vanilla Shader and adding a pack.mcmeta: same problem, and the Modrinth App would likely install it into resourcepacks, where Radiance doesn't look.
  • Hosting the pack outside Modrinth (GitHub Releases): works, but it can't be installed through the Modrinth App or added to Modrinth modpacks.
Additional context

How Radiance packs work, in case it helps:

  • Installed into the same "shaderpacks" folder as Iris and OptiFine packs.
  • A .zip (or folder) with a configs.json at the root, which contains a "radiance" entry with "shader_pack": true.
  • The shaders themselves are Vulkan GLSL (ray generation, hit and compute shaders), compiled by Radiance at runtime.

There are already some Radiance packs (Radiance ships its own built-in ones), so I don't think I'll be the only one. Thanks for considering it!

Image
Vorherrschende Sprache
Rust
Sterne
2.5k
Forks
663
Ø Merge
2 T. 11 Std.
Gemergte PRs (30 T.)
122

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus modrinth/code

Alle Issues in modrinth/code

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.