Add Radiance as a Shader Loader

Aberta
#8,166 0 comentários 1 reação 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
backend, full-stack

Direção de pesquisa

Start by locating the shader loader list, the upload validation that checks shader pack ZIP contents, and the Modrinth App logic that chooses the install folder; the issue does not name files or tests. Trace how Iris packs are validated and installed, then determine how Radiance should be represented across those entry points. Done means Radiance is selectable, ZIPs with a root configs.json are accepted, and the App installs packs to shaderpacks.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App, Modrinth.com website

Is your suggested feature related to a problem? Please describe.

Radiance has its own shader pack format, which isn't compatible with OptiFine, Iris, Canvas or vanilla shaders. I'm trying to publish one, but the version upload requires one of those four loaders, and each one checks the zip for its own files (a shaders/ folder or a pack.mcmeta). A Radiance pack has neither, so I can't upload it without tagging it with a loader it doesn't work with, which would mislead Iris and OptiFine users.

Radiance is a Vulkan ray-tracing renderer for Minecraft (NeoForge and Fabric), already published on Modrinth:

Source: https://github.com/Minecraft-Radiance/Radiance

Describe the solution you'd like

A new shader loader: Radiance. It would need:

  1. "Radiance" added to the shader loaders list.
  2. The upload check accepting a zip with configs.json at the root.
  3. The Modrinth App installing it into shaderpacks, like Iris packs.
Describe alternatives you've considered
  • Tagging the pack as Iris or OptiFine and adding an empty shaders/ folder: it would pass the check and install into the right folder, but Iris and OptiFine users would download a pack that does nothing for them.
  • Tagging it as Vanilla Shader and adding a pack.mcmeta: same problem, and the Modrinth App would likely install it into resourcepacks, where Radiance doesn't look.
  • Hosting the pack outside Modrinth (GitHub Releases): works, but it can't be installed through the Modrinth App or added to Modrinth modpacks.
Additional context

How Radiance packs work, in case it helps:

  • Installed into the same "shaderpacks" folder as Iris and OptiFine packs.
  • A .zip (or folder) with a configs.json at the root, which contains a "radiance" entry with "shader_pack": true.
  • The shaders themselves are Vulkan GLSL (ray generation, hit and compute shaders), compiled by Radiance at runtime.

There are already some Radiance packs (Radiance ships its own built-in ones), so I don't think I'll be the only one. Thanks for considering it!

Image
Linguagem predominante
Rust
Estrelas
2.5k
Forks
663
Merge médio
2d 11h
PRs com merge (30d)
122

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de modrinth/code

Todas as issues de modrinth/code

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.