Regression: a game still ends through four separate code paths
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 45/100
- Issue 類型
- 重構
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- javascript
研究方向
Read the listed ending paths in js/game.js, the save inference in js/saved-game.js, and the related tests tests/unit/review-result.test.js and tests/unit/draws-promotion.test.js. Start by running npm test and tracing how each ending updates state, stops the clock, and starts scoring. Done means end-state fields are assigned in one function and the acceptance tests cover each listed ending and its expected state.
由索引模型根據 Issue 內容生成。
描述
Summary
#140 moved the rule decision into gameOutcome, but the end state of a game is still written in four places, and they already behave differently. A related hidden coupling: updateStatusDisplay, which is a render call, also records the players and starts scoring the finished game. Every game ending therefore depends on a redraw happening.
Where
js/game.js:725-745(endWith)js/game.js:856-881(endGameWithoutMove)js/game.js:1686-1694(importPGNsets the end-state fields inline)js/game.js:799-802(Undo reopens a game by hand)js/game.js:637-638,js/game.js:835-836,js/game.js:1760(each caller ofplayMovemust rememberendIfAutomaticDraw)js/saved-game.js:114-122(result inference for old saves)js/game.js:1576-1584(updateStatusDisplaycallsrecordPlayers()andscoreFinishedGame())
Details
importPGN writes the end state itself instead of using either helper:
if (ending) {
isGameOver = true;
gameResult = ending.result;
endedWithoutMove = true;
currentStatus = ending.status;
}
playMove itself decides only checkmate and stalemate. Each caller then has to call endIfAutomaticDraw for repetition, the fifty-move rule and insufficient material.
Impact
The paths already differ: an imported ending plays no sound, and its clock handling differs from endGameWithoutMove. Anything new that must happen when a game ends, such as #160's results record, has to be added to every path. A future caller of playMove that forgets endIfAutomaticDraw would let a game continue past threefold repetition. If a state change ever skips updateStatusDisplay, scoring and player recording are skipped without any error.
Suggested fix
- Add
markEnded(result, status, { withoutMove }). HaveendWith,endGameWithoutMoveandimportPGNall set the end state through it. - Add
playAndJudge(from, to, promo)(that is,playMovefollowed byendIfAutomaticDraw) and use it inmakeMoveandredoMove. KeepimportPGNon plainplayMove, with a comment explaining why. - Call
recordPlayers()andscoreFinishedGame()from these transition helpers, and remove them fromupdateStatusDisplayin a separate commit. - Once old saves without a result can be dropped, remove the inference in
saved-game.js.
Acceptance criteria
- Before starting: one end-to-end test per ending (mate, stalemate, threefold via redo, fifty-move via redo, resignation, agreed draw, flag fall, PGN result tag). Each asserts
gameResult,endedWithoutMove, the status text, that the clock timer stopped, and that scoring started. - The end-state fields are assigned in one function.
Getting started
- Relevant files:
js/game.js,js/saved-game.js,tests/unit/review-result.test.js,tests/unit/draws-promotion.test.js - How to run tests:
npm test
Regression of #140.
Filed by repo-audit/full-audit at 01c6a35. Severity: medium. Effort: M. audit-key: tech-debt|js/game.js|endWith
- 主要語言
- JavaScript
- 星號
- 4
- 分支
- 2
- 平均合併
- 22 小時 16 分鐘
- 30 天內合併 PR
- 9
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
TMHSDigital/Static_Chess 的其他 Issue
-
enhancement help wanted severity: low
難度 4/5 3-5 天 新手友好度 55/100
TMHSDigital/Static_Chess#184 ·
維護者通常 1 天內回覆
-
enhancement help wanted severity: low
難度 4/5 3-5 天 新手友好度 58/100
TMHSDigital/Static_Chess#182 ·
維護者通常 1 天內回覆
-
severity: medium tech-debt
難度 5/5 一週以上 新手友好度 35/100
TMHSDigital/Static_Chess#171 ·
維護者通常 1 天內回覆
-
help wanted performance severity: medium
難度 5/5 一週以上 新手友好度 38/100
TMHSDigital/Static_Chess#168 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement help wanted severity: low
難度 4/5 3-5 天 新手友好度 61/100
TMHSDigital/Static_Chess#161 ·
維護者通常 1 天內回覆
查看 TMHSDigital/Static_Chess 的全部 Issue
相似的 Issue
-
priority: low server testing
難度 1/5 1 小時以內 新手友好度 88/100
blamechris/chroxy#9277 ·
維護者通常 1 天內回覆
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未關閉
難度 2/5 1-3 小時 新手友好度 62/100
microsoft/playwright#44289 ·
維護者通常 1 天內回覆
-
Bug
難度 2/5 1-3 小時 新手友好度 75/100
Ionaru/easy-markdown-editor#657 ·
-
難度 2/5 1-3 小時 新手友好度 66/100
TMHSDigital/Free-Game-Dev-Assets#320 ·
維護者通常 1 天內回覆
-
area:webapp bug finding
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆