Regression: a game still ends through four separate code paths
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 45/100
- Issue-Typ
- Refactoring
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- javascript
Rechercherichtung
Read the listed ending paths in js/game.js, the save inference in js/saved-game.js, and the related tests tests/unit/review-result.test.js and tests/unit/draws-promotion.test.js. Start by running npm test and tracing how each ending updates state, stops the clock, and starts scoring. Done means end-state fields are assigned in one function and the acceptance tests cover each listed ending and its expected state.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
#140 moved the rule decision into gameOutcome, but the end state of a game is still written in four places, and they already behave differently. A related hidden coupling: updateStatusDisplay, which is a render call, also records the players and starts scoring the finished game. Every game ending therefore depends on a redraw happening.
Where
js/game.js:725-745(endWith)js/game.js:856-881(endGameWithoutMove)js/game.js:1686-1694(importPGNsets the end-state fields inline)js/game.js:799-802(Undo reopens a game by hand)js/game.js:637-638,js/game.js:835-836,js/game.js:1760(each caller ofplayMovemust rememberendIfAutomaticDraw)js/saved-game.js:114-122(result inference for old saves)js/game.js:1576-1584(updateStatusDisplaycallsrecordPlayers()andscoreFinishedGame())
Details
importPGN writes the end state itself instead of using either helper:
if (ending) {
isGameOver = true;
gameResult = ending.result;
endedWithoutMove = true;
currentStatus = ending.status;
}
playMove itself decides only checkmate and stalemate. Each caller then has to call endIfAutomaticDraw for repetition, the fifty-move rule and insufficient material.
Impact
The paths already differ: an imported ending plays no sound, and its clock handling differs from endGameWithoutMove. Anything new that must happen when a game ends, such as #160's results record, has to be added to every path. A future caller of playMove that forgets endIfAutomaticDraw would let a game continue past threefold repetition. If a state change ever skips updateStatusDisplay, scoring and player recording are skipped without any error.
Suggested fix
- Add
markEnded(result, status, { withoutMove }). HaveendWith,endGameWithoutMoveandimportPGNall set the end state through it. - Add
playAndJudge(from, to, promo)(that is,playMovefollowed byendIfAutomaticDraw) and use it inmakeMoveandredoMove. KeepimportPGNon plainplayMove, with a comment explaining why. - Call
recordPlayers()andscoreFinishedGame()from these transition helpers, and remove them fromupdateStatusDisplayin a separate commit. - Once old saves without a result can be dropped, remove the inference in
saved-game.js.
Acceptance criteria
- Before starting: one end-to-end test per ending (mate, stalemate, threefold via redo, fifty-move via redo, resignation, agreed draw, flag fall, PGN result tag). Each asserts
gameResult,endedWithoutMove, the status text, that the clock timer stopped, and that scoring started. - The end-state fields are assigned in one function.
Getting started
- Relevant files:
js/game.js,js/saved-game.js,tests/unit/review-result.test.js,tests/unit/draws-promotion.test.js - How to run tests:
npm test
Regression of #140.
Filed by repo-audit/full-audit at 01c6a35. Severity: medium. Effort: M. audit-key: tech-debt|js/game.js|endWith
- Vorherrschende Sprache
- JavaScript
- Sterne
- 4
- Forks
- 2
- Ø Merge
- 22 Std. 16 Min.
- Gemergte PRs (30 T.)
- 9
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus TMHSDigital/Static_Chess
-
enhancement help wanted severity: low
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 55/100
TMHSDigital/Static_Chess#184 ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement help wanted severity: low
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 58/100
TMHSDigital/Static_Chess#182 ·
Maintainer antworten meist innerhalb von 1 Tag
-
severity: medium tech-debt
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 35/100
TMHSDigital/Static_Chess#171 ·
Maintainer antworten meist innerhalb von 1 Tag
-
help wanted performance severity: medium
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 38/100
TMHSDigital/Static_Chess#168 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement help wanted severity: low
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 61/100
TMHSDigital/Static_Chess#161 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in TMHSDigital/Static_Chess
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
cytoscape/cytoscape.js#3597 ·
Maintainer antworten meist innerhalb von 5 Tagen
-
priority: low server testing
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
blamechris/chroxy#9277 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 72/100
sunososobro-hub/cloudball#191 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
microsoft/playwright#44289 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Wire ISO post: has() accepts text values such as an empty string, true or 0x1A for wire numbersOffenarea:post effort:low enhancement P7 source:agent
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
Maintainer antworten meist innerhalb von 1 Tag