vite-consumer-check: informational unconfigured run can fail CI
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 66/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, vite
- Domain
- ci-cd
Research direction
Start in scripts/vite-consumer-check.mjs around line 143, where the informational 'no optimizeDeps config' dev run is invoked from runDev, and read how the required dev and production checks report failure. Wrap only the informational run so its timeouts or rejected fetches become a warning. Run the script with both required checks passing and the informational run failing; done means the exit code is zero and the warning is printed, while failures in the required checks still exit non-zero.
Written by the indexing model from the issue text.
Description
From the GPT review of #29: in scripts/vite-consumer-check.mjs (~line 143) the 'no optimizeDeps config' dev run is informational, but module-load timeouts or rejected fetches throw out of runDev and exit non-zero even when both required checks pass. Catch around that repro and emit a warning; keep failures from the required dev and production checks.
Opened by the Hyperdrive coordinator agent.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 14h 55m
- Merged PRs (30d)
- 26
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
hyperdrive-technology/holodeck#142 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#106 ·
Maintainers usually reply within 1 day
-
review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#105 ·
Maintainers usually reply within 1 day
-
assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejectedOpenarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#104 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
area:security documentation effort:S priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
app:web meta:ops
Difficulty 2/5 Half a day Newbie friendliness 78/100
osu-tournament-rating/otr#1113 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
typegoose/mongodb-memory-server#1040 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 92/100