provider-http: SSE id-only reset not applied to Last-Event-ID
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- api
Research direction
Start in packages/provider-http/src/channels.ts around lines 222–223 and read how event frames update lastEventId; then locate the provider-http tests for these channels. Add coverage for id-only updates and empty-id resets, and run the relevant package tests. Done means the reconnect header reflects id-only updates and is omitted after an empty reset.
Written by the indexing model from the issue text.
Description
From the PR #89 GPT review. In packages/provider-http/src/channels.ts:222-223, lastEventId is only updated inside onEvent, which runs only for frames that carry data. A frame with just id: (no data) is ignored. Scenario: the server sends id: 41 with data, then an empty id: to reset the cursor; on reconnect the client still sends Last-Event-ID: 41, and a server that has invalidated old cursors keeps rejecting the reconnect. Fix: update the id whenever a frame has an id field, even without data, as the WHATWG event-stream spec says; leave the header out after an empty reset; add tests for id-only updates and resets.
🤖 Generated with Claude Code
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 10h 39m
- Merged PRs (30d)
- 38
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
hyperdrive-technology/holodeck#196 ·
Maintainers usually reply within 1 day
-
area:docs review-finding
Difficulty 1/5 Under an hour Newbie friendliness 70/100
hyperdrive-technology/holodeck#180 ·
Maintainers usually reply within 1 day
-
Flaky E3 test: native cut with no keydown (holodeck#123) in editing-ux-render.test.tsPossibly taken @dezlitz claimed this today. Openarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejectedOpenarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#104 ·
Maintainers usually reply within 1 day
-
agent area:holodeck good first issue priority:p2
Difficulty 1/5 Under an hour Newbie friendliness 72/100
hyperdrive-technology/holodeck#64 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
"Contains" page watch never matches when its text has a trailing spacePossibly taken @RaphaelFakhri claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
CopilotKit/openmuse#184 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
bootstrap-vue-next/bootstrap-vue-next#3357 ·
Maintainers usually reply within 1 day
-
[quality] tide.ts: six mutation survivors in the merge-queue gate, draft refusal, fork-403 workflow-file diagnosis and getPull's fork flag are unpinned by any testPossibly taken @hivecommons-hive claimed this today. Openagent/quality needs-kind stage/040-covered-by-pr testing
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
cncf/prow-github-actions#517 · 1 comment ·
Maintainers usually reply within 2 days
-
Unsampled pageload span is profiled when profileLifecycle is 'trace' (browser UI profiling)Possibly taken @Jxxunnn claimed this today. OpenBrowser Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
getsentry/sentry-javascript#25497 · 1 comment ·
Maintainers usually reply within 1 day