Question menu settings show the old value for 400 ms, and a quick change back is lost

Abierto
#3,970 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
64/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, typescript
Área
frontend

Línea de trabajo

Start in src/composables/useQuestion.ts at onExtraSettingsChange() and the debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms), then look at the menu controls that bind to props.extraSettings (the rating "Highest rating" select and the linear scale's lowest/highest selects). Reproduce on a form with a rating or linear scale question: pick a new value and watch the control lag, then pick the saved value back within 400 ms. Done when the control reflects the pick immediately and the last pick wins; verify by hand in the editor, since no test is named.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

0. Needs triage bug

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug
Settings in a question's menu that are saved as extra settings go through onExtraSettingsChange() in src/composables/useQuestion.ts, which batches them and saves them through a debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms). Until that save runs, props.extraSettings still holds the saved value, and the controls are bound to it. This has two effects:

  1. A select such as "Highest rating" (or the lowest/highest value of a linear scale) keeps showing the old value for up to 400 ms after a new one is picked.
  2. Picking the saved value again within those 400 ms is lost: the control's model value already equals the saved value, so no change is emitted, and the pending other value is saved instead.

To Reproduce
Steps to reproduce the behavior:

  1. Edit a form with a rating question (#3637) or a linear scale.
  2. Open the question's menu and pick another value in the "Highest rating" select, e.g. 7 instead of 10.
  3. Watch the select: it shows 10 at about 300 ms and 7 at about 600 ms.
  4. Pick a value, then pick the previously saved value again within 400 ms: the first pick is saved.

Expected behavior
The control shows the picked value at once, and the last pick is the one saved, however quickly the user changes it.

A possible fix: keep the pending extra settings in a reactive local state that the controls read (saved value merged with pending changes), or flush the pending save before a control that shows the saved value is updated. The fix belongs in useQuestion, as all question types that save extra settings from their menu share this path.

Screenshots
N/A

Nextcloud (please complete the following information):

  • Nextcloud-Version: 36 (dev)
  • Forms-Version: main (5.5 development) with #3637

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Microsoft Edge (Chromium)
  • Version: current

Smartphone (please complete the following information):

N/A

Browser log

No errors are logged; the behaviour follows from the debounce.

Additional context
Found in the review of #3637 (rating question). Validated and reproduced on a live Nextcloud 36 instance with the rating question of #3637: the select timing was measured, and the lost second pick was reproduced for the icon choice before #3637 switched it to @change. The "Highest rating" select is left as is in #3637, as the fix belongs in useQuestion. The linear scale's lowest and highest value selects use the same code path; they were not reproduced separately.

Assisted by Claude Code:claude-opus-5-5

Lenguaje dominante
JavaScript
Estrellas
385
Forks
133
Merge medio
7 h 54 min
PR fusionados (30 d)
157

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de nextcloud/forms

Todos los issues de nextcloud/forms

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.