Question menu settings show the old value for 400 ms, and a quick change back is lost
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 64/100
- Type d'issue
- Bug
- Clarté
- Clairement spécifiée
- Activité
- Active
- Stack technique
- javascript, typescript
- Domaine
- frontend
Piste de recherche
Start in src/composables/useQuestion.ts at onExtraSettingsChange() and the debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms), then look at the menu controls that bind to props.extraSettings (the rating "Highest rating" select and the linear scale's lowest/highest selects). Reproduce on a form with a rating or linear scale question: pick a new value and watch the control lag, then pick the saved value back within 400 ms. Done when the control reflects the pick immediately and the last pick wins; verify by hand in the editor, since no test is named.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!
Describe the bug
Settings in a question's menu that are saved as extra settings go through onExtraSettingsChange() in src/composables/useQuestion.ts, which batches them and saves them through a debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms). Until that save runs, props.extraSettings still holds the saved value, and the controls are bound to it. This has two effects:
- A select such as "Highest rating" (or the lowest/highest value of a linear scale) keeps showing the old value for up to 400 ms after a new one is picked.
- Picking the saved value again within those 400 ms is lost: the control's model value already equals the saved value, so no change is emitted, and the pending other value is saved instead.
To Reproduce
Steps to reproduce the behavior:
- Edit a form with a rating question (#3637) or a linear scale.
- Open the question's menu and pick another value in the "Highest rating" select, e.g. 7 instead of 10.
- Watch the select: it shows 10 at about 300 ms and 7 at about 600 ms.
- Pick a value, then pick the previously saved value again within 400 ms: the first pick is saved.
Expected behavior
The control shows the picked value at once, and the last pick is the one saved, however quickly the user changes it.
A possible fix: keep the pending extra settings in a reactive local state that the controls read (saved value merged with pending changes), or flush the pending save before a control that shows the saved value is updated. The fix belongs in useQuestion, as all question types that save extra settings from their menu share this path.
Screenshots
N/A
Nextcloud (please complete the following information):
- Nextcloud-Version: 36 (dev)
- Forms-Version:
main(5.5 development) with #3637
Desktop (please complete the following information):
- OS: Windows 11
- Browser: Microsoft Edge (Chromium)
- Version: current
Smartphone (please complete the following information):
N/A
Browser log
No errors are logged; the behaviour follows from the debounce.
Additional context
Found in the review of #3637 (rating question). Validated and reproduced on a live Nextcloud 36 instance with the rating question of #3637: the select timing was measured, and the lost second pick was reproduced for the icon choice before #3637 switched it to @change. The "Highest rating" select is left as is in #3637, as the fix belongs in useQuestion. The linear scale's lowest and highest value selects use the same code path; they were not reproduced separately.
Assisted by Claude Code:claude-opus-5-5
- Langage dominant
- JavaScript
- Étoiles
- 385
- Forks
- 133
- Merge moyen
- 7 h 54 min
- PR mergées (30 j)
- 157
Préparer son environnement
Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.
- Aucun Dockerfile ni fichier Docker Compose
- Aucun modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de nextcloud/forms
-
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
-
Allow a team to own a formOuverte1. to develop enhancement
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 35/100
nextcloud/forms#3841 · 1 réaction ·
Les mainteneurs répondent en général sous 1 jour
-
0. Needs triage bug
Difficulté 3/5 1-2 jours Accessibilité débutants 45/100
nextcloud/forms#3831 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
1. to develop enhancement
Difficulté 4/5 3-5 jours Accessibilité débutants 22/100
nextcloud/forms#3829 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de nextcloud/forms
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
cytoscape/cytoscape.js#3597 ·
Les mainteneurs répondent en général sous 5 jours
-
priority: low server testing
Difficulté 1/5 Moins d'une heure Accessibilité débutants 88/100
blamechris/chroxy#9277 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 72/100
sunososobro-hub/cloudball#191 ·
Les mainteneurs répondent en général sous 1 jour
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 62/100
microsoft/playwright#44289 ·
Les mainteneurs répondent en général sous 1 jour
-
Wire ISO post: has() accepts text values such as an empty string, true or 0x1A for wire numbersOuvertearea:post effort:low enhancement P7 source:agent
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
Les mainteneurs répondent en général sous 1 jour