Question menu settings show the old value for 400 ms, and a quick change back is lost

未关闭
#3,970 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
64/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
领域
frontend

调研方向

Start in src/composables/useQuestion.ts at onExtraSettingsChange() and the debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms), then look at the menu controls that bind to props.extraSettings (the rating "Highest rating" select and the linear scale's lowest/highest selects). Reproduce on a form with a rating or linear scale question: pick a new value and watch the control lag, then pick the saved value back within 400 ms. Done when the control reflects the pick immediately and the last pick wins; verify by hand in the editor, since no test is named.

由索引模型根据 Issue 内容生成。

描述

0. Needs triage bug

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug
Settings in a question's menu that are saved as extra settings go through onExtraSettingsChange() in src/composables/useQuestion.ts, which batches them and saves them through a debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms). Until that save runs, props.extraSettings still holds the saved value, and the controls are bound to it. This has two effects:

  1. A select such as "Highest rating" (or the lowest/highest value of a linear scale) keeps showing the old value for up to 400 ms after a new one is picked.
  2. Picking the saved value again within those 400 ms is lost: the control's model value already equals the saved value, so no change is emitted, and the pending other value is saved instead.

To Reproduce
Steps to reproduce the behavior:

  1. Edit a form with a rating question (#3637) or a linear scale.
  2. Open the question's menu and pick another value in the "Highest rating" select, e.g. 7 instead of 10.
  3. Watch the select: it shows 10 at about 300 ms and 7 at about 600 ms.
  4. Pick a value, then pick the previously saved value again within 400 ms: the first pick is saved.

Expected behavior
The control shows the picked value at once, and the last pick is the one saved, however quickly the user changes it.

A possible fix: keep the pending extra settings in a reactive local state that the controls read (saved value merged with pending changes), or flush the pending save before a control that shows the saved value is updated. The fix belongs in useQuestion, as all question types that save extra settings from their menu share this path.

Screenshots
N/A

Nextcloud (please complete the following information):

  • Nextcloud-Version: 36 (dev)
  • Forms-Version: main (5.5 development) with #3637

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Microsoft Edge (Chromium)
  • Version: current

Smartphone (please complete the following information):

N/A

Browser log

No errors are logged; the behaviour follows from the debounce.

Additional context
Found in the review of #3637 (rating question). Validated and reproduced on a live Nextcloud 36 instance with the rating question of #3637: the select timing was measured, and the lost second pick was reproduced for the icon choice before #3637 switched it to @change. The "Highest rating" select is left as is in #3637, as the fix belongs in useQuestion. The linear scale's lowest and highest value selects use the same code path; they were not reproduced separately.

Assisted by Claude Code:claude-opus-5-5

主要语言
JavaScript
星标
385
派生
133
平均合并
7 小时 54 分钟
30 天内合并 PR
157

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

nextcloud/forms 的其他 Issue

查看 nextcloud/forms 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。