Question menu settings show the old value for 400 ms, and a quick change back is lost
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 64/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- javascript, typescript
- 領域
- frontend
調査の方向性
Start in src/composables/useQuestion.ts at onExtraSettingsChange() and the debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms), then look at the menu controls that bind to props.extraSettings (the rating "Highest rating" select and the linear scale's lowest/highest selects). Reproduce on a form with a rating or linear scale question: pick a new value and watch the control lag, then pick the saved value back within 400 ms. Done when the control reflects the pick immediately and the last pick wins; verify by hand in the editor, since no test is named.
索引モデルが issue の本文から書いたものです。
説明
Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!
Describe the bug
Settings in a question's menu that are saved as extra settings go through onExtraSettingsChange() in src/composables/useQuestion.ts, which batches them and saves them through a debounced saveExtraSettings() (INPUT_DEBOUNCE_MS, 400 ms). Until that save runs, props.extraSettings still holds the saved value, and the controls are bound to it. This has two effects:
- A select such as "Highest rating" (or the lowest/highest value of a linear scale) keeps showing the old value for up to 400 ms after a new one is picked.
- Picking the saved value again within those 400 ms is lost: the control's model value already equals the saved value, so no change is emitted, and the pending other value is saved instead.
To Reproduce
Steps to reproduce the behavior:
- Edit a form with a rating question (#3637) or a linear scale.
- Open the question's menu and pick another value in the "Highest rating" select, e.g. 7 instead of 10.
- Watch the select: it shows 10 at about 300 ms and 7 at about 600 ms.
- Pick a value, then pick the previously saved value again within 400 ms: the first pick is saved.
Expected behavior
The control shows the picked value at once, and the last pick is the one saved, however quickly the user changes it.
A possible fix: keep the pending extra settings in a reactive local state that the controls read (saved value merged with pending changes), or flush the pending save before a control that shows the saved value is updated. The fix belongs in useQuestion, as all question types that save extra settings from their menu share this path.
Screenshots
N/A
Nextcloud (please complete the following information):
- Nextcloud-Version: 36 (dev)
- Forms-Version:
main(5.5 development) with #3637
Desktop (please complete the following information):
- OS: Windows 11
- Browser: Microsoft Edge (Chromium)
- Version: current
Smartphone (please complete the following information):
N/A
Browser log
No errors are logged; the behaviour follows from the debounce.
Additional context
Found in the review of #3637 (rating question). Validated and reproduced on a live Nextcloud 36 instance with the rating question of #3637: the select timing was measured, and the lost second pick was reproduced for the icon choice before #3637 switched it to @change. The "Highest rating" select is left as is in #3637, as the fix belongs in useQuestion. The linear scale's lowest and highest value selects use the same code path; they were not reproduced separately.
Assisted by Claude Code:claude-opus-5-5
- 主要言語
- JavaScript
- スター
- 385
- フォーク
- 133
- 平均マージ
- 7時間 54分
- マージ済み PR(30日)
- 157
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
nextcloud/forms のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
1. to develop enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
nextcloud/forms#3841 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
0. Needs triage bug
難易度 3/5 1〜2日 初心者へのやさしさ 45/100
nextcloud/forms#3831 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
1. to develop enhancement
難易度 4/5 3〜5日 初心者へのやさしさ 22/100
nextcloud/forms#3829 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
nextcloud/forms の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
cytoscape/cytoscape.js#3597 ·
メンテナーはふだん 5 日以内に返信
-
priority: low server testing
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
blamechris/chroxy#9277 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 72/100
sunososobro-hub/cloudball#191 ·
メンテナーはふだん 1 日以内に返信
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
microsoft/playwright#44289 ·
メンテナーはふだん 1 日以内に返信
-
Wire ISO post: has() accepts text values such as an empty string, true or 0x1A for wire numbersオープンarea:post effort:low enhancement P7 source:agent
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信