Docker: five images ignore docker stop and are killed at the timeout

Abierto
#5,611 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
docker, typescript

Línea de trabajo

Read the five affected image definitions under src/filesystem, src/sequentialthinking, src/fetch, src/git, and src/time, then compare their stop behavior with everything and memory. Run the provided Docker reproduction and inspect scripts/image-smoke.mjs for the cleanStop checks. Done means all five containers stop promptly with their server's exit and the smoke entries assert clean stops; the signal handling approach still needs a decision.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement v2

Problem

Five of the seven Docker images do not exit on docker stop: filesystem, sequentialthinking, fetch, git and time. Docker sends the stop signal, the server ignores it, and Docker kills the container when its timeout runs out (exit 137). everything and memory exit on their own (exit 0 and 130), because their images declare STOPSIGNAL SIGINT and their servers handle it (#5485 for memory).

The cause is the same in each: the server runs as PID 1, which gets no default signal disposition, so a SIGTERM it installed no handler for is dropped.

Found while building the image smoke for #5598, which asserts a clean stop only for the two images that have one today.

Reproduce

Built from v2/main at 7f383a8e, Docker 29.8.1:

docker build -f src/filesystem/Dockerfile -t mcp/filesystem .
id=$(docker run -d -i mcp/filesystem /tmp)
docker stop "$id"                                   # waits out the timeout
docker inspect -f '{{.State.ExitCode}}' "$id"       # 137

The same for sequentialthinking, and for fetch, git and time built from their own directories. All five exit 137; everything exits 0 and memory 130.

Expected

docker stop ends each container promptly and with the server's own exit, as it does for everything and memory. None of the five keeps state that a kill corrupts today, so what a user sees is the stop taking the full timeout (10 seconds by default), per container, on every docker stop, docker compose down or orchestrator restart, most visibly when the server runs over Streamable HTTP.

To decide

  • Per image: a STOPSIGNAL the server already handles, a signal handler in the server, or an init process (docker run --init, tini) in the image.
  • When an image gains a clean stop, set cleanStop: true on its entry in scripts/image-smoke.mjs, so the image smoke asserts it (a script test already requires it of any image that declares a STOPSIGNAL).
Lenguaje dominante
TypeScript
Estrellas
92k
Forks
12k
Merge medio
3 h 46 min
PR fusionados (30 d)
206

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de modelcontextprotocol/servers

Todos los issues de modelcontextprotocol/servers

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.