Server-side Remote Config: evaluate() throws SyntaxError when a custom signal regex condition uses RE2-only syntax such as (?i)
Los mantenedores suelen responder en 2 días
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Stack tecnológico
- firebase, javascript, node.js, typescript
Línea de trabajo
Start with the server-side Remote Config ConditionEvaluator and ServerTemplate.evaluate() behavior described in the issue, then inspect the existing evaluator tests. Reproduce the failure using a custom signal regex with (?i) and check how invalid patterns affect unrelated conditions and parameters. Done means evaluation does not throw and other conditions continue to work; an open linked pull request already addresses this issue.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
[REQUIRED] Step 2: Describe your environment
- Operating System version: Linux (aarch64)
- Firebase SDK version: firebase-admin 14.5.1 (from npm; also reproduces on current
main) - Firebase Product: remote-config (server-side templates)
- Node.js version: 24.14.1
- NPM version: 11.11.0
[REQUIRED] Step 3: Describe the problem
The condition reference documents that custom signal .matches([...]) conditions use RE2 syntax ("Uses RE2 syntax"). The server-side evaluator compiles each target with new RegExp(target). Some valid RE2 patterns are rejected by the JavaScript engine. The most common one is the inline case-insensitive flag (?i). Others are (?s) and named groups written (?P<name>...).
When a template contains such a condition, new RegExp() throws. Nothing in ConditionEvaluator catches the error, so ServerTemplate.evaluate() throws a raw SyntaxError for every evaluation context. This happens even when the user's signal value would never match that condition, and even for parameters that do not reference it. One condition therefore breaks every parameter in the template for every request.
The comment in evaluate() says it should only throw when no template is loaded, and should "return false in cases where the SDK is unsure how to evaluate the fetched template". The Go Admin SDK uses Go's regexp package, which implements the RE2 syntax that the docs specify. It evaluates the same template without error and returns false when a pattern cannot be compiled.
Steps to reproduce:
const { initializeApp } = require('firebase-admin/app');
const { getRemoteConfig } = require('firebase-admin/remote-config');
const template = {
conditions: [
{ name: 'premium_users', condition: { customSignal: {
customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
targetCustomSignalValues: ['(?i)premium'] } } },
{ name: 'beta_users', condition: { customSignal: {
customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
targetCustomSignalValues: ['beta'] } } },
],
parameters: {
show_ads: { defaultValue: { value: 'true' },
conditionalValues: { premium_users: { value: 'false' } } },
new_checkout: { defaultValue: { value: 'false' },
conditionalValues: { beta_users: { value: 'true' } } },
},
etag: 'etag-1',
version: { versionNumber: '1' },
};
const app = initializeApp({ projectId: 'demo-project' });
const st = getRemoteConfig(app).initServerTemplate({ template: JSON.stringify(template) });
for (const plan of ['Premium-Annual', 'beta-tester', 'free']) {
try {
const cfg = st.evaluate({ plan });
console.log(plan, cfg.getString('show_ads'), cfg.getString('new_checkout'));
} catch (e) {
console.log(plan, 'threw', e.constructor.name, e.message);
}
}
Actual output:
Premium-Annual threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
beta-tester threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
free threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
The same template evaluated with the Go Admin SDK (v4.23.0, InitServerTemplate + Evaluate):
plan=Premium-Annual: show_ads=false new_checkout=false
plan=beta-tester: show_ads=true new_checkout=true
plan=free: show_ads=true new_checkout=false
Expected: evaluate() should not throw because of one condition. At a minimum, a pattern that the JavaScript engine cannot compile should evaluate to false, which is what the Go SDK does on a compile error. The other conditions and parameters should still be evaluated.
A fix that catches the compile error and returns false stops the outage. It does not make (?i) itself match the way RE2 does: in Node, the Premium-Annual row would still get show_ads=true. Translating RE2 inline flags into JavaScript flags could be a separate follow-up if that is wanted.
This issue was drafted with Claude Code (claude-opus-5-5); the results above are from the runs described.
- Lenguaje dominante
- TypeScript
- Estrellas
- 1.8k
- Forks
- 429
- Merge medio
- 4 d 19 h
- PR fusionados (30 d)
- 14
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de firebase/firebase-admin-node
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
firebase/firebase-admin-node#3319 ·
Los mantenedores suelen responder en 2 días
-
getToken() replays a failed token refresh to later callers while a valid token is cachedPosiblemente ocupada @lahirumaramba la tomó hace 11 días. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
firebase/firebase-admin-node#3234 · 2 comentarios · 1 asignado ·
Los mantenedores suelen responder en 2 días
-
Misleading error message for THIRD_PARTY_AUTH_ERROR: raw "OAuth 2 access token" text surfaced instead of the APNs-specific messagePosiblemente ocupada @milcho0604 la tomó hace 97 días. Abiertoapi: messaging
Dificultad 3/5 1-2 días Aptitud para principiantes 70/100
firebase/firebase-admin-node#3215 ·
Los mantenedores suelen responder en 2 días
-
api: messaging
Dificultad 5/5 Más de una semana Aptitud para principiantes 28/100
firebase/firebase-admin-node#3214 ·
Los mantenedores suelen responder en 2 días
-
[Firestore] Re-export functions from '@google-cloud/firestore/pipelines'Quizá libre de nuevo @jonathanedey la tomó hace 140 días y no hay ningún pull request abierto. Abiertoapi: firestore type: feature request
firebase/firebase-admin-node#3183 · 1 comentario · 1 reacción · 1 asignado ·
Los mantenedores suelen responder en 2 días
Todos los issues de firebase/firebase-admin-node
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Los mantenedores suelen responder en 1 día
-
ai-driven-qa bug claude Cosmetic
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
Domain / chatbot New
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
Inist-CNRS/lodex#3861 ·
Los mantenedores suelen responder en 1 día
-
area:agent-sdk area:docs documentation enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
anthropics/claude-code#110914 ·
-
area/cli platform/windows type/bug version/v2
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
anomalyco/opencode#64631 · 1 comentario ·
Los mantenedores suelen responder en 1 día