Server-side Remote Config: evaluate() throws SyntaxError when a custom signal regex condition uses RE2-only syntax such as (?i)
維護者通常 2 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 35/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 停滯
- 技術堆疊
- firebase, javascript, node.js, typescript
研究方向
Start with the server-side Remote Config ConditionEvaluator and ServerTemplate.evaluate() behavior described in the issue, then inspect the existing evaluator tests. Reproduce the failure using a custom signal regex with (?i) and check how invalid patterns affect unrelated conditions and parameters. Done means evaluation does not throw and other conditions continue to work; an open linked pull request already addresses this issue.
由索引模型根據 Issue 內容生成。
描述
[REQUIRED] Step 2: Describe your environment
- Operating System version: Linux (aarch64)
- Firebase SDK version: firebase-admin 14.5.1 (from npm; also reproduces on current
main) - Firebase Product: remote-config (server-side templates)
- Node.js version: 24.14.1
- NPM version: 11.11.0
[REQUIRED] Step 3: Describe the problem
The condition reference documents that custom signal .matches([...]) conditions use RE2 syntax ("Uses RE2 syntax"). The server-side evaluator compiles each target with new RegExp(target). Some valid RE2 patterns are rejected by the JavaScript engine. The most common one is the inline case-insensitive flag (?i). Others are (?s) and named groups written (?P<name>...).
When a template contains such a condition, new RegExp() throws. Nothing in ConditionEvaluator catches the error, so ServerTemplate.evaluate() throws a raw SyntaxError for every evaluation context. This happens even when the user's signal value would never match that condition, and even for parameters that do not reference it. One condition therefore breaks every parameter in the template for every request.
The comment in evaluate() says it should only throw when no template is loaded, and should "return false in cases where the SDK is unsure how to evaluate the fetched template". The Go Admin SDK uses Go's regexp package, which implements the RE2 syntax that the docs specify. It evaluates the same template without error and returns false when a pattern cannot be compiled.
Steps to reproduce:
const { initializeApp } = require('firebase-admin/app');
const { getRemoteConfig } = require('firebase-admin/remote-config');
const template = {
conditions: [
{ name: 'premium_users', condition: { customSignal: {
customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
targetCustomSignalValues: ['(?i)premium'] } } },
{ name: 'beta_users', condition: { customSignal: {
customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
targetCustomSignalValues: ['beta'] } } },
],
parameters: {
show_ads: { defaultValue: { value: 'true' },
conditionalValues: { premium_users: { value: 'false' } } },
new_checkout: { defaultValue: { value: 'false' },
conditionalValues: { beta_users: { value: 'true' } } },
},
etag: 'etag-1',
version: { versionNumber: '1' },
};
const app = initializeApp({ projectId: 'demo-project' });
const st = getRemoteConfig(app).initServerTemplate({ template: JSON.stringify(template) });
for (const plan of ['Premium-Annual', 'beta-tester', 'free']) {
try {
const cfg = st.evaluate({ plan });
console.log(plan, cfg.getString('show_ads'), cfg.getString('new_checkout'));
} catch (e) {
console.log(plan, 'threw', e.constructor.name, e.message);
}
}
Actual output:
Premium-Annual threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
beta-tester threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
free threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
The same template evaluated with the Go Admin SDK (v4.23.0, InitServerTemplate + Evaluate):
plan=Premium-Annual: show_ads=false new_checkout=false
plan=beta-tester: show_ads=true new_checkout=true
plan=free: show_ads=true new_checkout=false
Expected: evaluate() should not throw because of one condition. At a minimum, a pattern that the JavaScript engine cannot compile should evaluate to false, which is what the Go SDK does on a compile error. The other conditions and parameters should still be evaluated.
A fix that catches the compile error and returns false stops the outage. It does not make (?i) itself match the way RE2 does: in Node, the Premium-Annual row would still get show_ads=true. Translating RE2 inline flags into JavaScript flags could be a separate follow-up if that is wanted.
This issue was drafted with Claude Code (claude-opus-5-5); the results above are from the runs described.
- 主要語言
- TypeScript
- 星號
- 1.8k
- 分支
- 429
- 平均合併
- 4 天 19 小時
- 30 天內合併 PR
- 14
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
firebase/firebase-admin-node 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 62/100
firebase/firebase-admin-node#3319 ·
維護者通常 2 天內回覆
-
getToken() replays a failed token refresh to later callers while a valid token is cached可能已有人在做 @lahirumaramba 於 11 天前認領。 未關閉
難度 3/5 1-2 天 新手友好度 35/100
firebase/firebase-admin-node#3234 · 2 則留言 · 已指派 1 人 ·
維護者通常 2 天內回覆
-
Misleading error message for THIRD_PARTY_AUTH_ERROR: raw "OAuth 2 access token" text surfaced instead of the APNs-specific message可能已有人在做 @milcho0604 於 97 天前認領。 未關閉api: messaging
難度 3/5 1-2 天 新手友好度 70/100
firebase/firebase-admin-node#3215 ·
維護者通常 2 天內回覆
-
api: messaging
難度 5/5 一週以上 新手友好度 28/100
firebase/firebase-admin-node#3214 ·
維護者通常 2 天內回覆
-
[Firestore] Re-export functions from '@google-cloud/firestore/pipelines'可能重新可做 @jonathanedey 於 140 天前認領,目前沒有進行中的 PR。 未關閉api: firestore type: feature request
firebase/firebase-admin-node#3183 · 1 則留言 · 1 個 reaction · 已指派 1 人 ·
維護者通常 2 天內回覆
查看 firebase/firebase-admin-node 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 1 天內回覆
-
ai-driven-qa bug claude Cosmetic
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
Domain / chatbot New
難度 2/5 1-3 小時 新手友好度 65/100
Inist-CNRS/lodex#3861 ·
維護者通常 1 天內回覆
-
area:agent-sdk area:docs documentation enhancement
難度 2/5 1-3 小時 新手友好度 66/100
anthropics/claude-code#110914 ·
-
area/cli platform/windows type/bug version/v2
難度 2/5 1-3 小時 新手友好度 70/100
anomalyco/opencode#64631 · 1 則留言 ·
維護者通常 1 天內回覆