Server-side Remote Config: evaluate() throws SyntaxError when a custom signal regex condition uses RE2-only syntax such as (?i)

未关闭
#3,320 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

@0z5a 已经在做这个了。

开始于 2026年11月16日。

  • #3321 来自 @0z5a —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
firebase, javascript, node.js, typescript
领域
backend, testing

调研方向

Start with the server-side Remote Config ConditionEvaluator and ServerTemplate.evaluate() behavior described in the issue, then inspect the existing evaluator tests. Reproduce the failure using a custom signal regex with (?i) and check how invalid patterns affect unrelated conditions and parameters. Done means evaluation does not throw and other conditions continue to work; an open linked pull request already addresses this issue.

由索引模型根据 Issue 内容生成。

描述

[REQUIRED] Step 2: Describe your environment
  • Operating System version: Linux (aarch64)
  • Firebase SDK version: firebase-admin 14.5.1 (from npm; also reproduces on current main)
  • Firebase Product: remote-config (server-side templates)
  • Node.js version: 24.14.1
  • NPM version: 11.11.0
[REQUIRED] Step 3: Describe the problem

The condition reference documents that custom signal .matches([...]) conditions use RE2 syntax ("Uses RE2 syntax"). The server-side evaluator compiles each target with new RegExp(target). Some valid RE2 patterns are rejected by the JavaScript engine. The most common one is the inline case-insensitive flag (?i). Others are (?s) and named groups written (?P<name>...).

When a template contains such a condition, new RegExp() throws. Nothing in ConditionEvaluator catches the error, so ServerTemplate.evaluate() throws a raw SyntaxError for every evaluation context. This happens even when the user's signal value would never match that condition, and even for parameters that do not reference it. One condition therefore breaks every parameter in the template for every request.

The comment in evaluate() says it should only throw when no template is loaded, and should "return false in cases where the SDK is unsure how to evaluate the fetched template". The Go Admin SDK uses Go's regexp package, which implements the RE2 syntax that the docs specify. It evaluates the same template without error and returns false when a pattern cannot be compiled.

Steps to reproduce:
const { initializeApp } = require('firebase-admin/app');
const { getRemoteConfig } = require('firebase-admin/remote-config');

const template = {
  conditions: [
    { name: 'premium_users', condition: { customSignal: {
      customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
      targetCustomSignalValues: ['(?i)premium'] } } },
    { name: 'beta_users', condition: { customSignal: {
      customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
      targetCustomSignalValues: ['beta'] } } },
  ],
  parameters: {
    show_ads: { defaultValue: { value: 'true' },
      conditionalValues: { premium_users: { value: 'false' } } },
    new_checkout: { defaultValue: { value: 'false' },
      conditionalValues: { beta_users: { value: 'true' } } },
  },
  etag: 'etag-1',
  version: { versionNumber: '1' },
};

const app = initializeApp({ projectId: 'demo-project' });
const st = getRemoteConfig(app).initServerTemplate({ template: JSON.stringify(template) });
for (const plan of ['Premium-Annual', 'beta-tester', 'free']) {
  try {
    const cfg = st.evaluate({ plan });
    console.log(plan, cfg.getString('show_ads'), cfg.getString('new_checkout'));
  } catch (e) {
    console.log(plan, 'threw', e.constructor.name, e.message);
  }
}

Actual output:

Premium-Annual threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
beta-tester threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
free threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group

The same template evaluated with the Go Admin SDK (v4.23.0, InitServerTemplate + Evaluate):

plan=Premium-Annual: show_ads=false new_checkout=false
plan=beta-tester: show_ads=true new_checkout=true
plan=free: show_ads=true new_checkout=false

Expected: evaluate() should not throw because of one condition. At a minimum, a pattern that the JavaScript engine cannot compile should evaluate to false, which is what the Go SDK does on a compile error. The other conditions and parameters should still be evaluated.

A fix that catches the compile error and returns false stops the outage. It does not make (?i) itself match the way RE2 does: in Node, the Premium-Annual row would still get show_ads=true. Translating RE2 inline flags into JavaScript flags could be a separate follow-up if that is wanted.

This issue was drafted with Claude Code (claude-opus-5-5); the results above are from the runs described.

主要语言
TypeScript
星标
1.8k
派生
429
平均合并
4 天 19 小时
30 天内合并 PR
14

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

firebase/firebase-admin-node 的其他 Issue

查看 firebase/firebase-admin-node 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。