Server-side Remote Config: evaluate() throws SyntaxError when a custom signal regex condition uses RE2-only syntax such as (?i)

オープン
#3,320 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

@0z5a がすでに取り組んでいます。

2026年11月16日 から。

  • #3321 @0z5a による — オープン

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
停滞
技術スタック
firebase, javascript, node.js, typescript
領域
backend, testing

調査の方向性

Start with the server-side Remote Config ConditionEvaluator and ServerTemplate.evaluate() behavior described in the issue, then inspect the existing evaluator tests. Reproduce the failure using a custom signal regex with (?i) and check how invalid patterns affect unrelated conditions and parameters. Done means evaluation does not throw and other conditions continue to work; an open linked pull request already addresses this issue.

索引モデルが issue の本文から書いたものです。

説明

[REQUIRED] Step 2: Describe your environment
  • Operating System version: Linux (aarch64)
  • Firebase SDK version: firebase-admin 14.5.1 (from npm; also reproduces on current main)
  • Firebase Product: remote-config (server-side templates)
  • Node.js version: 24.14.1
  • NPM version: 11.11.0
[REQUIRED] Step 3: Describe the problem

The condition reference documents that custom signal .matches([...]) conditions use RE2 syntax ("Uses RE2 syntax"). The server-side evaluator compiles each target with new RegExp(target). Some valid RE2 patterns are rejected by the JavaScript engine. The most common one is the inline case-insensitive flag (?i). Others are (?s) and named groups written (?P<name>...).

When a template contains such a condition, new RegExp() throws. Nothing in ConditionEvaluator catches the error, so ServerTemplate.evaluate() throws a raw SyntaxError for every evaluation context. This happens even when the user's signal value would never match that condition, and even for parameters that do not reference it. One condition therefore breaks every parameter in the template for every request.

The comment in evaluate() says it should only throw when no template is loaded, and should "return false in cases where the SDK is unsure how to evaluate the fetched template". The Go Admin SDK uses Go's regexp package, which implements the RE2 syntax that the docs specify. It evaluates the same template without error and returns false when a pattern cannot be compiled.

Steps to reproduce:
const { initializeApp } = require('firebase-admin/app');
const { getRemoteConfig } = require('firebase-admin/remote-config');

const template = {
  conditions: [
    { name: 'premium_users', condition: { customSignal: {
      customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
      targetCustomSignalValues: ['(?i)premium'] } } },
    { name: 'beta_users', condition: { customSignal: {
      customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
      targetCustomSignalValues: ['beta'] } } },
  ],
  parameters: {
    show_ads: { defaultValue: { value: 'true' },
      conditionalValues: { premium_users: { value: 'false' } } },
    new_checkout: { defaultValue: { value: 'false' },
      conditionalValues: { beta_users: { value: 'true' } } },
  },
  etag: 'etag-1',
  version: { versionNumber: '1' },
};

const app = initializeApp({ projectId: 'demo-project' });
const st = getRemoteConfig(app).initServerTemplate({ template: JSON.stringify(template) });
for (const plan of ['Premium-Annual', 'beta-tester', 'free']) {
  try {
    const cfg = st.evaluate({ plan });
    console.log(plan, cfg.getString('show_ads'), cfg.getString('new_checkout'));
  } catch (e) {
    console.log(plan, 'threw', e.constructor.name, e.message);
  }
}

Actual output:

Premium-Annual threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
beta-tester threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
free threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group

The same template evaluated with the Go Admin SDK (v4.23.0, InitServerTemplate + Evaluate):

plan=Premium-Annual: show_ads=false new_checkout=false
plan=beta-tester: show_ads=true new_checkout=true
plan=free: show_ads=true new_checkout=false

Expected: evaluate() should not throw because of one condition. At a minimum, a pattern that the JavaScript engine cannot compile should evaluate to false, which is what the Go SDK does on a compile error. The other conditions and parameters should still be evaluated.

A fix that catches the compile error and returns false stops the outage. It does not make (?i) itself match the way RE2 does: in Node, the Premium-Annual row would still get show_ads=true. Translating RE2 inline flags into JavaScript flags could be a separate follow-up if that is wanted.

This issue was drafted with Claude Code (claude-opus-5-5); the results above are from the runs described.

主要言語
TypeScript
スター
1.8k
フォーク
429
平均マージ
4日 19時間
マージ済み PR(30日)
14

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

firebase/firebase-admin-node のほかの issue

firebase/firebase-admin-node の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。