[FR] Allow @google-cloud/storage v9 — v8 emits MaxListenersExceededWarning on every download (teeny-request stream path)

Abierto Apto para principiantes
#3,319 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
62/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
google-cloud, node.js, typescript
Área
backend, devtools

Línea de trabajo

Empieza por leer los metadatos del paquete que declaran @google-cloud/storage como dependencia opcional y comprueba las pruebas de compatibilidad de dependencias existentes. Amplía el rango admitido para incluir ^9.0.0, ejecuta después la suite de pruebas pertinente y confirma que se acepta Storage 9. La tarea estará completa cuando el rango declarado y las pruebas admitan la nueva versión principal.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Is your feature request related to a problem? Please describe.

[email protected] declares @google-cloud/storage as ^8.1.0 (optionalDependencies), so an Admin SDK app resolves Storage 8.4.0. On that version every File.createReadStream() / File.download() emits a MaxListenersExceededWarning:

(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [PassThrough]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [PassThrough]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit

(These are copied verbatim from our production logs. The error and close warnings arrive as a pair, within a millisecond of each other.)

It is not a leak (heap stays flat over hundreds of downloads). But Node prints it to stderr, outside any structured logger, and to anyone reading the logs it looks like a leak.

The cause, as far as we traced it (Storage 8.4.0, teeny-request 11.1.1, Node 24):

  • teeny-request's stream mode pipes the response into its requestStream PassThrough (teeny-request/build/src/index.js, pipeline(responseStream, requestStream, ...));
  • Storage's createReadStream pipes that same raw response stream again, into its throughStream (@google-cloud/storage/build/cjs/src/file.js, pipeline(rawResponseStream, ...transformStreams, throughStream, onComplete));
  • together with node-fetch's own pipeline, three stream.pipeline calls attach their error and close listeners to the one PassThrough, which crosses the default limit of 10.

@google-cloud/[email protected] (released 2026-11-12) no longer depends on teeny-request (it uses gaxios 8), which removes this code path. We have not yet confirmed that the warning is gone on Storage 9; we're inferring it from the dependency change. Admin SDK users can't take Storage 9 without an overrides entry outside the SDK's declared range.

Describe the solution you'd like

Widen the @google-cloud/storage range to allow ^9.0.0 (its engines is node >=22, the same as firebase-admin@14), once it passes your test suite.

Describe alternatives you've considered

  • npm overrides forcing Storage 9: it works around the warning, but it runs the app on a Storage major the SDK hasn't been tested against.
  • emitter.setMaxListeners() / --no-warnings: these hide the symptom and also hide real listener leaks.

Additional context

  • firebase-admin 14.5.0 / 14.5.1, @google-cloud/storage 8.4.0, teeny-request 11.1.1, Node.js 24.
  • We've seen it both in production (Cloud Run, Node 24) and against the Firebase Storage emulator.
Lenguaje dominante
TypeScript
Estrellas
1.8k
Forks
429
Merge medio
4 d 19 h
PR fusionados (30 d)
14

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de firebase/firebase-admin-node

Todos los issues de firebase/firebase-admin-node

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.