Server-side Remote Config: evaluate() throws SyntaxError when a custom signal regex condition uses RE2-only syntax such as (?i)

Ouverte
#3,320 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

@0z5a y travaille déjà.

Depuis le 16/11/2026.

  • #3321 par @0z5a — ouverte

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
firebase, javascript, node.js, typescript
Domaine
backend, testing

Piste de recherche

Start with the server-side Remote Config ConditionEvaluator and ServerTemplate.evaluate() behavior described in the issue, then inspect the existing evaluator tests. Reproduce the failure using a custom signal regex with (?i) and check how invalid patterns affect unrelated conditions and parameters. Done means evaluation does not throw and other conditions continue to work; an open linked pull request already addresses this issue.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

[REQUIRED] Step 2: Describe your environment
  • Operating System version: Linux (aarch64)
  • Firebase SDK version: firebase-admin 14.5.1 (from npm; also reproduces on current main)
  • Firebase Product: remote-config (server-side templates)
  • Node.js version: 24.14.1
  • NPM version: 11.11.0
[REQUIRED] Step 3: Describe the problem

The condition reference documents that custom signal .matches([...]) conditions use RE2 syntax ("Uses RE2 syntax"). The server-side evaluator compiles each target with new RegExp(target). Some valid RE2 patterns are rejected by the JavaScript engine. The most common one is the inline case-insensitive flag (?i). Others are (?s) and named groups written (?P<name>...).

When a template contains such a condition, new RegExp() throws. Nothing in ConditionEvaluator catches the error, so ServerTemplate.evaluate() throws a raw SyntaxError for every evaluation context. This happens even when the user's signal value would never match that condition, and even for parameters that do not reference it. One condition therefore breaks every parameter in the template for every request.

The comment in evaluate() says it should only throw when no template is loaded, and should "return false in cases where the SDK is unsure how to evaluate the fetched template". The Go Admin SDK uses Go's regexp package, which implements the RE2 syntax that the docs specify. It evaluates the same template without error and returns false when a pattern cannot be compiled.

Steps to reproduce:
const { initializeApp } = require('firebase-admin/app');
const { getRemoteConfig } = require('firebase-admin/remote-config');

const template = {
  conditions: [
    { name: 'premium_users', condition: { customSignal: {
      customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
      targetCustomSignalValues: ['(?i)premium'] } } },
    { name: 'beta_users', condition: { customSignal: {
      customSignalOperator: 'STRING_CONTAINS_REGEX', customSignalKey: 'plan',
      targetCustomSignalValues: ['beta'] } } },
  ],
  parameters: {
    show_ads: { defaultValue: { value: 'true' },
      conditionalValues: { premium_users: { value: 'false' } } },
    new_checkout: { defaultValue: { value: 'false' },
      conditionalValues: { beta_users: { value: 'true' } } },
  },
  etag: 'etag-1',
  version: { versionNumber: '1' },
};

const app = initializeApp({ projectId: 'demo-project' });
const st = getRemoteConfig(app).initServerTemplate({ template: JSON.stringify(template) });
for (const plan of ['Premium-Annual', 'beta-tester', 'free']) {
  try {
    const cfg = st.evaluate({ plan });
    console.log(plan, cfg.getString('show_ads'), cfg.getString('new_checkout'));
  } catch (e) {
    console.log(plan, 'threw', e.constructor.name, e.message);
  }
}

Actual output:

Premium-Annual threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
beta-tester threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group
free threw SyntaxError Invalid regular expression: /(?i)premium/: Invalid group

The same template evaluated with the Go Admin SDK (v4.23.0, InitServerTemplate + Evaluate):

plan=Premium-Annual: show_ads=false new_checkout=false
plan=beta-tester: show_ads=true new_checkout=true
plan=free: show_ads=true new_checkout=false

Expected: evaluate() should not throw because of one condition. At a minimum, a pattern that the JavaScript engine cannot compile should evaluate to false, which is what the Go SDK does on a compile error. The other conditions and parameters should still be evaluated.

A fix that catches the compile error and returns false stops the outage. It does not make (?i) itself match the way RE2 does: in Node, the Premium-Annual row would still get show_ads=true. Translating RE2 inline flags into JavaScript flags could be a separate follow-up if that is wanted.

This issue was drafted with Claude Code (claude-opus-5-5); the results above are from the runs described.

Langage dominant
TypeScript
Étoiles
1.8k
Forks
429
Merge moyen
4 j 19 h
PR mergées (30 j)
14

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de firebase/firebase-admin-node

Toutes les issues de firebase/firebase-admin-node

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.