Review player: timestamped notes for the agent (saved as markers)

Abierto
#376 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
58/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, typescript

Línea de trabajo

Start with assets/ui/player.js:378-382 to follow the existing ui/update-model-context call, then read assets/ui/player.js:124-143 and src/tools/addMarker.ts:59 for marker display and creation. The issue also points to assets/ui/player.html and src/utils/player.ts; inspect how the player handles controls and chapters. Done when notes persist as markers, appear in chapters, reach the agent with timecodes and frames, and the controls are keyboard and screen-reader accessible.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: medium enhancement help wanted priority: high

Summary

The review player can only send the agent one thing: "the user exported X". A person reviewing an agent's recording has no way to say "this is wrong" at a given moment. Add Note at playhead, so they can leave timestamped feedback that becomes a marker and reaches the agent on its next turn.

Where

  • assets/ui/player.js:378-382 (the only ui/update-model-context call, sent after export)
  • assets/ui/player.js:124-143 (markers are shown read-only)
  • src/tools/addMarker.ts:59 (add_marker can already mark a file at at seconds)

Details

The player is the human half of a review loop: the agent records, the person watches. Today the person's verdict has to be typed into chat with timestamps they read off the HUD. Markers are already shown on the timeline and carried through edits as chapters (#174), so notes fit the existing model.

Suggested fix

  • An Add note button (and N) opens a one-line input at the current playhead.
  • On save: call add_marker with { input, at, label }, add the tick and list entry, and send ui/update-model-context with { t, note, frame } (the frame as image content, so the agent sees what the person saw).
  • Notes can be edited or deleted before the next turn.

Acceptance criteria

  • A note made in the player shows up as a marker on reload and in chapters
  • The agent's next turn includes each note with its timecode and frame
  • Keyboard and screen-reader accessible, like the other #243 controls

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/addMarker.ts, src/utils/player.ts

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|notes

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
8 h 17 min
PR fusionados (30 d)
46

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.