Review player: limit a redaction box to a time window

Abierto
#377 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@lucky0559 ya está trabajando en esto.

Desde el 19/11/2026.

  • #381 de @lucky0559 — cerrado sin fusionar
  • #382 de @lucky0559 — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
typescript
Área
frontend

Línea de trabajo

Start with assets/ui/player.html and assets/ui/player.js to trace the box form, box list, stage drawing, and export; read src/tools/redactRegion.ts for the existing start and end behavior. Run npm test and inspect the generated regions assertion. Done means boxes can be time-limited by pointer and keyboard, display only while active, and export their window; an open linked pull request indicates work is already underway.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: small enhancement good first issue priority: medium

Summary

Redaction boxes drawn in the review player cover the whole kept range. redact_region and pipeline redact already support a start..end window per region, but the player cannot set one. A notification that sits on screen for 3 seconds gets blurred for the whole video.

Where

  • assets/ui/player.html:137-146 (box form: X, Y, W, H only)
  • assets/ui/player.js:367 (regions: S.boxes.map((b) => ({ ...b })), with no time fields)
  • src/tools/redactRegion.ts:15 ("each optionally limited to start..end seconds")

Suggested fix

  • A new box defaults to "whole video". Add a From playhead / To playhead pair (or a small range on the timeline under the box) to limit it.
  • Show each box's window in #boxList (01:10.0–01:13.5) and only draw a box on the stage while the playhead is inside its window.
  • Export includes start/end when set.

Acceptance criteria

  • Boxes can be limited to a time window, by pointer and by keyboard
  • Stage shows only the boxes active at the current frame
  • Export passes the window. A test checks the generated regions

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html
  • Tests: npm test

Filed by repo-audit/feature-ideas at 1ac339f. Severity: medium. Effort: S. audit-key: enhancement|assets/ui/player.js|boxTimeRange

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
8 h 17 min
PR fusionados (30 d)
46

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.