Review player: timestamped notes for the agent (saved as markers)

Aperta
#376 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, typescript

Direzione di ricerca

Start with assets/ui/player.js:378-382 to follow the existing ui/update-model-context call, then read assets/ui/player.js:124-143 and src/tools/addMarker.ts:59 for marker display and creation. The issue also points to assets/ui/player.html and src/utils/player.ts; inspect how the player handles controls and chapters. Done when notes persist as markers, appear in chapters, reach the agent with timecodes and frames, and the controls are keyboard and screen-reader accessible.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

effort: medium enhancement help wanted priority: high

Summary

The review player can only send the agent one thing: "the user exported X". A person reviewing an agent's recording has no way to say "this is wrong" at a given moment. Add Note at playhead, so they can leave timestamped feedback that becomes a marker and reaches the agent on its next turn.

Where

  • assets/ui/player.js:378-382 (the only ui/update-model-context call, sent after export)
  • assets/ui/player.js:124-143 (markers are shown read-only)
  • src/tools/addMarker.ts:59 (add_marker can already mark a file at at seconds)

Details

The player is the human half of a review loop: the agent records, the person watches. Today the person's verdict has to be typed into chat with timestamps they read off the HUD. Markers are already shown on the timeline and carried through edits as chapters (#174), so notes fit the existing model.

Suggested fix

  • An Add note button (and N) opens a one-line input at the current playhead.
  • On save: call add_marker with { input, at, label }, add the tick and list entry, and send ui/update-model-context with { t, note, frame } (the frame as image content, so the agent sees what the person saw).
  • Notes can be edited or deleted before the next turn.

Acceptance criteria

  • A note made in the player shows up as a marker on reload and in chapters
  • The agent's next turn includes each note with its timecode and frame
  • Keyboard and screen-reader accessible, like the other #243 controls

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/addMarker.ts, src/utils/player.ts

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|notes

Lingua principale
TypeScript
Stelle
1
Fork
4
Merge medio
8h 17m
PR unite (30g)
46

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/screencast-mcp

Tutte le issue di TMHSDigital/screencast-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.