Review player: keyboard shortcuts (play/pause, set IN/OUT, draw, delete box)

Abierto
#380 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
node.js, typescript

Línea de trabajo

Start with assets/ui/player.js, especially the existing slider keydown handlers and the keyTarget pattern. Read the player markup in assets/ui/player.html and run npm test to locate the relevant tests. Add the player-wide shortcuts, an accessible keyboard-reachable shortcut list, and tests for the key map; done means the listed shortcuts work outside text and number inputs and the tests pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: small enhancement good first issue priority: low

Summary

The review player has no player-wide shortcuts. Keys only work while one of the three sliders has focus (arrows, Page Up/Down, Home/End). Reviewing a recording means reaching for the mouse for play/pause, setting IN/OUT at the playhead, and deleting a box.

Where

  • assets/ui/player.js:214-241 (keydown handlers on #seek, #hIn, #hOut only)
  • assets/ui/player.js:243 (Play is click-only)
  • assets/ui/player.html:118 (hint text documents only drag and arrows)

Suggested fix

Add a keydown handler on the player root that ignores events from inputs:

  • Space / K play/pause, J / L step back/forward one frame, , / . as aliases
  • I / O set IN / OUT at the playhead
  • D toggle draw mode, Delete remove the focused box, Esc cancel a draft box
  • ? shows a small shortcut list, and the hint line mentions it

Acceptance criteria

  • Shortcuts work wherever focus is in the player, except inside text and number inputs
  • Shortcut list is reachable by keyboard and announced to screen readers
  • Tests for the key map (pure function like keyTarget)

Getting started

  • Relevant file: assets/ui/player.js (keyTarget shows the existing pattern)
  • Tests: npm test

Filed by repo-audit/feature-ideas at 1ac339f. Severity: low. Effort: S. audit-key: enhancement|assets/ui/player.js|shortcuts

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
8 h 17 min
PR fusionados (30 d)
46

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.