Review player: timestamped notes for the agent (saved as markers)

Ouverte
#376 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
1-2 jours
Accessibilité débutants
58/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
javascript, typescript

Piste de recherche

Start with assets/ui/player.js:378-382 to follow the existing ui/update-model-context call, then read assets/ui/player.js:124-143 and src/tools/addMarker.ts:59 for marker display and creation. The issue also points to assets/ui/player.html and src/utils/player.ts; inspect how the player handles controls and chapters. Done when notes persist as markers, appear in chapters, reach the agent with timecodes and frames, and the controls are keyboard and screen-reader accessible.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

effort: medium enhancement help wanted priority: high

Summary

The review player can only send the agent one thing: "the user exported X". A person reviewing an agent's recording has no way to say "this is wrong" at a given moment. Add Note at playhead, so they can leave timestamped feedback that becomes a marker and reaches the agent on its next turn.

Where

  • assets/ui/player.js:378-382 (the only ui/update-model-context call, sent after export)
  • assets/ui/player.js:124-143 (markers are shown read-only)
  • src/tools/addMarker.ts:59 (add_marker can already mark a file at at seconds)

Details

The player is the human half of a review loop: the agent records, the person watches. Today the person's verdict has to be typed into chat with timestamps they read off the HUD. Markers are already shown on the timeline and carried through edits as chapters (#174), so notes fit the existing model.

Suggested fix

  • An Add note button (and N) opens a one-line input at the current playhead.
  • On save: call add_marker with { input, at, label }, add the tick and list entry, and send ui/update-model-context with { t, note, frame } (the frame as image content, so the agent sees what the person saw).
  • Notes can be edited or deleted before the next turn.

Acceptance criteria

  • A note made in the player shows up as a marker on reload and in chapters
  • The agent's next turn includes each note with its timecode and frame
  • Keyboard and screen-reader accessible, like the other #243 controls

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/addMarker.ts, src/utils/player.ts

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|notes

Langage dominant
TypeScript
Étoiles
1
Forks
4
Merge moyen
8 h 17 min
PR mergées (30 j)
46

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/screencast-mcp

Toutes les issues de TMHSDigital/screencast-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.