Review player: timestamped notes for the agent (saved as markers)

未關閉
#376 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
1-2 天
新手友好度
58/100
Issue 類型
功能
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
javascript, typescript

研究方向

Start with assets/ui/player.js:378-382 to follow the existing ui/update-model-context call, then read assets/ui/player.js:124-143 and src/tools/addMarker.ts:59 for marker display and creation. The issue also points to assets/ui/player.html and src/utils/player.ts; inspect how the player handles controls and chapters. Done when notes persist as markers, appear in chapters, reach the agent with timecodes and frames, and the controls are keyboard and screen-reader accessible.

由索引模型根據 Issue 內容生成。

描述

effort: medium enhancement help wanted priority: high

Summary

The review player can only send the agent one thing: "the user exported X". A person reviewing an agent's recording has no way to say "this is wrong" at a given moment. Add Note at playhead, so they can leave timestamped feedback that becomes a marker and reaches the agent on its next turn.

Where

  • assets/ui/player.js:378-382 (the only ui/update-model-context call, sent after export)
  • assets/ui/player.js:124-143 (markers are shown read-only)
  • src/tools/addMarker.ts:59 (add_marker can already mark a file at at seconds)

Details

The player is the human half of a review loop: the agent records, the person watches. Today the person's verdict has to be typed into chat with timestamps they read off the HUD. Markers are already shown on the timeline and carried through edits as chapters (#174), so notes fit the existing model.

Suggested fix

  • An Add note button (and N) opens a one-line input at the current playhead.
  • On save: call add_marker with { input, at, label }, add the tick and list entry, and send ui/update-model-context with { t, note, frame } (the frame as image content, so the agent sees what the person saw).
  • Notes can be edited or deleted before the next turn.

Acceptance criteria

  • A note made in the player shows up as a marker on reload and in chapters
  • The agent's next turn includes each note with its timecode and frame
  • Keyboard and screen-reader accessible, like the other #243 controls

Getting started

  • Relevant files: assets/ui/player.js, assets/ui/player.html, src/tools/addMarker.ts, src/utils/player.ts

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|assets/ui/player.js|notes

主要語言
TypeScript
星號
1
分支
4
平均合併
8 小時 17 分鐘
30 天內合併 PR
46

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/screencast-mcp 的其他 Issue

查看 TMHSDigital/screencast-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。