Cut middle sections: pipeline 'cut' op with ranges, and Cut selection in the review player

Abierto
#375 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
42/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Read src/utils/pipelineStep.ts and src/utils/pipelineRun.ts to see how pipeline operations are defined and executed, then trace the keep-list path in src/utils/transcriptCut.ts and inspect the selection and export flow in assets/ui/player.js. Run the existing pipeline tests and add coverage for merging overlapping or unsorted ranges and for the new operation. Done means cuts retime sidecars and keep audio in sync, and the player can add, list, undo, and export multiple cut ranges.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: medium enhancement help wanted priority: high

Summary

Neither the review player nor pipeline can remove a stretch from the middle of a recording. The player has a single IN/OUT pair, and the pipeline trim op keeps one segment. Removing "the 20 s where I typed my password" or "the wrong turn at 1:10" needs a multi-range cut.

Where

  • assets/ui/player.js:168-173, 368-369 (one inI/outI pair, exported as one trim)
  • src/utils/pipelineStep.ts:21-26 (trim: start, end/duration only)
  • src/tools/cutByTranscript.ts:17 (remove cuts ranges, but only by quoting transcript text)
  • src/tools/cutIdle.ts (cuts ranges, but only ones it detects itself)

Details

The cut machinery already exists inside cut_idle and cut_by_transcript (keep-list, concat, audio kept in sync, sidecars retimed), but there is no way to say "remove 12.0-31.5 and 70-74" directly.

Suggested fix

  1. Add a pipeline op { op: "cut", ranges: [{ start, end }, ...] } (and remove on trim if that fits better) that reuses the cut_idle / transcript-cut keep-list path. Markers, event logs, and .edit.json retime the same way.
  2. In the player, add Cut selection: select a range on the timeline and press it (or X) to mark it removed. Removed ranges are shaded, listed, and can be undone. Export sends one cut step after redact and before trim.

Acceptance criteria

  • pipeline accepts cut with overlapping and unsorted ranges, and merges them
  • Output duration = input − removed; audio stays in sync
  • Player can mark, list, and remove several cut ranges, by keyboard as well as by pointer
  • Tests for range merging and the pipeline op

Getting started

  • Relevant files: src/utils/pipelineStep.ts, src/utils/pipelineRun.ts, src/utils/transcriptCut.ts, assets/ui/player.js
  • Run npm run docs after changing the pipeline schema

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|src/utils/pipelineStep.ts|cut

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
8 h 17 min
PR fusionados (30 d)
46

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.