Cut middle sections: pipeline 'cut' op with ranges, and Cut selection in the review player

未關閉
#375 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
5/5
預估耗時
一週以上
新手友好度
42/100
Issue 類型
功能
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
typescript

研究方向

Read src/utils/pipelineStep.ts and src/utils/pipelineRun.ts to see how pipeline operations are defined and executed, then trace the keep-list path in src/utils/transcriptCut.ts and inspect the selection and export flow in assets/ui/player.js. Run the existing pipeline tests and add coverage for merging overlapping or unsorted ranges and for the new operation. Done means cuts retime sidecars and keep audio in sync, and the player can add, list, undo, and export multiple cut ranges.

由索引模型根據 Issue 內容生成。

描述

effort: medium enhancement help wanted priority: high

Summary

Neither the review player nor pipeline can remove a stretch from the middle of a recording. The player has a single IN/OUT pair, and the pipeline trim op keeps one segment. Removing "the 20 s where I typed my password" or "the wrong turn at 1:10" needs a multi-range cut.

Where

  • assets/ui/player.js:168-173, 368-369 (one inI/outI pair, exported as one trim)
  • src/utils/pipelineStep.ts:21-26 (trim: start, end/duration only)
  • src/tools/cutByTranscript.ts:17 (remove cuts ranges, but only by quoting transcript text)
  • src/tools/cutIdle.ts (cuts ranges, but only ones it detects itself)

Details

The cut machinery already exists inside cut_idle and cut_by_transcript (keep-list, concat, audio kept in sync, sidecars retimed), but there is no way to say "remove 12.0-31.5 and 70-74" directly.

Suggested fix

  1. Add a pipeline op { op: "cut", ranges: [{ start, end }, ...] } (and remove on trim if that fits better) that reuses the cut_idle / transcript-cut keep-list path. Markers, event logs, and .edit.json retime the same way.
  2. In the player, add Cut selection: select a range on the timeline and press it (or X) to mark it removed. Removed ranges are shaded, listed, and can be undone. Export sends one cut step after redact and before trim.

Acceptance criteria

  • pipeline accepts cut with overlapping and unsorted ranges, and merges them
  • Output duration = input − removed; audio stays in sync
  • Player can mark, list, and remove several cut ranges, by keyboard as well as by pointer
  • Tests for range merging and the pipeline op

Getting started

  • Relevant files: src/utils/pipelineStep.ts, src/utils/pipelineRun.ts, src/utils/transcriptCut.ts, assets/ui/player.js
  • Run npm run docs after changing the pipeline schema

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|src/utils/pipelineStep.ts|cut

主要語言
TypeScript
星號
1
分支
4
平均合併
8 小時 17 分鐘
30 天內合併 PR
46

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/screencast-mcp 的其他 Issue

查看 TMHSDigital/screencast-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。