Cut middle sections: pipeline 'cut' op with ranges, and Cut selection in the review player

未关闭
#375 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
42/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript

调研方向

Read src/utils/pipelineStep.ts and src/utils/pipelineRun.ts to see how pipeline operations are defined and executed, then trace the keep-list path in src/utils/transcriptCut.ts and inspect the selection and export flow in assets/ui/player.js. Run the existing pipeline tests and add coverage for merging overlapping or unsorted ranges and for the new operation. Done means cuts retime sidecars and keep audio in sync, and the player can add, list, undo, and export multiple cut ranges.

由索引模型根据 Issue 内容生成。

描述

effort: medium enhancement help wanted priority: high

Summary

Neither the review player nor pipeline can remove a stretch from the middle of a recording. The player has a single IN/OUT pair, and the pipeline trim op keeps one segment. Removing "the 20 s where I typed my password" or "the wrong turn at 1:10" needs a multi-range cut.

Where

  • assets/ui/player.js:168-173, 368-369 (one inI/outI pair, exported as one trim)
  • src/utils/pipelineStep.ts:21-26 (trim: start, end/duration only)
  • src/tools/cutByTranscript.ts:17 (remove cuts ranges, but only by quoting transcript text)
  • src/tools/cutIdle.ts (cuts ranges, but only ones it detects itself)

Details

The cut machinery already exists inside cut_idle and cut_by_transcript (keep-list, concat, audio kept in sync, sidecars retimed), but there is no way to say "remove 12.0-31.5 and 70-74" directly.

Suggested fix

  1. Add a pipeline op { op: "cut", ranges: [{ start, end }, ...] } (and remove on trim if that fits better) that reuses the cut_idle / transcript-cut keep-list path. Markers, event logs, and .edit.json retime the same way.
  2. In the player, add Cut selection: select a range on the timeline and press it (or X) to mark it removed. Removed ranges are shaded, listed, and can be undone. Export sends one cut step after redact and before trim.

Acceptance criteria

  • pipeline accepts cut with overlapping and unsorted ranges, and merges them
  • Output duration = input − removed; audio stays in sync
  • Player can mark, list, and remove several cut ranges, by keyboard as well as by pointer
  • Tests for range merging and the pipeline op

Getting started

  • Relevant files: src/utils/pipelineStep.ts, src/utils/pipelineRun.ts, src/utils/transcriptCut.ts, assets/ui/player.js
  • Run npm run docs after changing the pipeline schema

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|src/utils/pipelineStep.ts|cut

主要语言
TypeScript
星标
1
派生
4
平均合并
8 小时 17 分钟
30 天内合并 PR
46

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/screencast-mcp 的其他 Issue

查看 TMHSDigital/screencast-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。