Cut middle sections: pipeline 'cut' op with ranges, and Cut selection in the review player

Ouverte
#375 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
42/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript

Piste de recherche

Read src/utils/pipelineStep.ts and src/utils/pipelineRun.ts to see how pipeline operations are defined and executed, then trace the keep-list path in src/utils/transcriptCut.ts and inspect the selection and export flow in assets/ui/player.js. Run the existing pipeline tests and add coverage for merging overlapping or unsorted ranges and for the new operation. Done means cuts retime sidecars and keep audio in sync, and the player can add, list, undo, and export multiple cut ranges.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

effort: medium enhancement help wanted priority: high

Summary

Neither the review player nor pipeline can remove a stretch from the middle of a recording. The player has a single IN/OUT pair, and the pipeline trim op keeps one segment. Removing "the 20 s where I typed my password" or "the wrong turn at 1:10" needs a multi-range cut.

Where

  • assets/ui/player.js:168-173, 368-369 (one inI/outI pair, exported as one trim)
  • src/utils/pipelineStep.ts:21-26 (trim: start, end/duration only)
  • src/tools/cutByTranscript.ts:17 (remove cuts ranges, but only by quoting transcript text)
  • src/tools/cutIdle.ts (cuts ranges, but only ones it detects itself)

Details

The cut machinery already exists inside cut_idle and cut_by_transcript (keep-list, concat, audio kept in sync, sidecars retimed), but there is no way to say "remove 12.0-31.5 and 70-74" directly.

Suggested fix

  1. Add a pipeline op { op: "cut", ranges: [{ start, end }, ...] } (and remove on trim if that fits better) that reuses the cut_idle / transcript-cut keep-list path. Markers, event logs, and .edit.json retime the same way.
  2. In the player, add Cut selection: select a range on the timeline and press it (or X) to mark it removed. Removed ranges are shaded, listed, and can be undone. Export sends one cut step after redact and before trim.

Acceptance criteria

  • pipeline accepts cut with overlapping and unsorted ranges, and merges them
  • Output duration = input − removed; audio stays in sync
  • Player can mark, list, and remove several cut ranges, by keyboard as well as by pointer
  • Tests for range merging and the pipeline op

Getting started

  • Relevant files: src/utils/pipelineStep.ts, src/utils/pipelineRun.ts, src/utils/transcriptCut.ts, assets/ui/player.js
  • Run npm run docs after changing the pipeline schema

Filed by repo-audit/feature-ideas at 1ac339f. Severity: high. Effort: M. audit-key: enhancement|src/utils/pipelineStep.ts|cut

Langage dominant
TypeScript
Étoiles
1
Forks
4
Merge moyen
8 h 17 min
PR mergées (30 j)
46

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/screencast-mcp

Toutes les issues de TMHSDigital/screencast-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.