Let pipeline and its recipes blur on-screen secrets (OCR scan) in the same call

Abierto
#341 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start with src/tools/pipeline.ts and src/utils/recipes.ts, then read src/cli.ts around redactCopy and src/utils/ocrScan.ts to understand the existing OCR flow. Run npm test to see the project’s current checks. Done means pipeline redaction and recipe options can scan source frames for secrets and turn matches into timed regions, with the CLI logic shared as described; the default behavior for recipes remains an open question.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: medium enhancement priority: high

Summary

The pipeline redact op takes only explicit regions, and the pr_demo / tutorial / social_reel recipes never scan for secrets. The OCR-scan-then-blur flow exists, but only as private CLI code (redactCopy). Making a demo shareable safely therefore takes find_text, then redact_region (a full re-encode), then pipeline.

Where

  • src/tools/pipeline.ts:65-71 (redact op schema)
  • src/utils/recipes.ts:30-60
  • src/cli.ts:591-630 (redactCopy: find_text { scanEverySec, query: DEFAULT_SECRET_PATTERN, regex, redact: true } then redact_region)

Impact

The main "make this shareable" path can publish a token that showed on screen unless the agent remembers a separate two-tool pass, which costs an extra re-encode.

Proposal

Add secrets?: boolean | { pattern?: string } to the pipeline redact op, and a redactSecrets option on recipes, planned as a pre-pass like cut_idle and transcribe (pending probes): run scanVideoFrames + scanMatches on the source and turn the matches into timed redact regions. These are source-coordinate ops, which recipes already place before zoom/reframe (recipes.ts:67). Move redactCopy's logic into a util shared by the CLI, bug_report and pipeline.

Open question: should recipes turn it on by default when OCR is available (matching the consent-by-default stance of #266)?

Getting started

  • Relevant files: src/tools/pipeline.ts, src/utils/recipes.ts, src/cli.ts, src/utils/ocrScan.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: high. Effort: M. audit-key: enhancement|src/tools/pipeline.ts|redact.secrets

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
14 h 8 min
PR fusionados (30 d)
48

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.