Tests for wait_for_change handler validation, the wgc path and text mode

Abierto
#350 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
76/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
testing

Línea de trabajo

Read src/tools/waitForChange.ts and the existing mocking pattern in startRecording.test.ts:45-54; run npm test to see the current test setup. Add handler tests for the validation, WGC, text mode, cleanup, keep, and cancellation cases listed in the issue, using mocked capture helpers. Done when those cases pass without relying on a live screen.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: medium help wanted priority: medium testing

Summary

The loops behind wait_for_change are unit-tested, but the handler that wires them runs only in the capture smoke and the opt-in local test. toolLayer.test.ts skips it because it polls a live screen. Local coverage: 32.4% lines / 26.5% branches.

Where

  • src/tools/waitForChange.ts:108-110 (mode/text mismatch), :118 (wgc needs one window), :138-147 (wgc size probe and temp-dir cleanup), :184-203 (text mode, gone), :219-223 (finally cleanup), :239-252 (keep/returnImage/cancelled)
  • src/__tests__/integration/toolLayer.test.ts:45

Impact

wait_for_change is the recommended replacement for sleeps in agent flows. A wrong elapsedSec, a leaked screencast-wait-* temp dir, or a broken text mode would not be caught on any CI leg except by the flaky Windows smoke.

Suggested fix

Handler tests with runFfmpegFrames, captureStill, readFrames and resolveCaptureTarget mocked (vi.mock, as in startRecording.test.ts:45-54):

  • mode "text" without text, and text without mode: isError with the "Use text with mode" message.
  • backend "wgc" with target "full": isError "watches one window".
  • wgc first still probes to 0x0: isError, and no screencast-wait-* dir left in tmpdir.
  • mode text, OCR finds the text: outcome "met" with matches; with gone: true: gone: true.
  • grab throws mid-loop: isError, stream aborted, work dir removed.
  • keep:true: screenshotPath exists; keep:false: the temp shot is removed; cancelled: no image.

Getting started

  • Relevant files: src/tools/waitForChange.ts, src/utils/waitLoop.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: M. audit-key: testing|src/tools/waitForChange.ts|register

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
14 h 8 min
PR fusionados (30 d)
48

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.