Tests for the start_recording startWhen/stopWhen arm path and its consent carry-over

Abierto
#349 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
70/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend, testing

Línea de trabajo

Read src/tools/startRecording.ts around the listed arm and watcher paths, then inspect src/__tests__/startRecording.test.ts, src/__tests__/consentLogging.test.ts, and src/utils/triggers.ts. Extend the fake spawn tests with an elicitation capable client and mocked window and text checks, then run npm test. Done means the listed startWhen, consent carry-over, failed arm, and stopWhen cases pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort: medium priority: medium testing

Summary

armRecording asks for consent once at arm time, adds the args object to approvedAtArm, and later calls tool.handler(startArgs, ...). prepareStart skips the consent prompt when approvedAtArm.has(args). This relies on the handler receiving the very same object. watchStopWhen stops a session when OCR text appears. No test covers startWhen, stopWhen or approvedAtArm: triggers.test.ts covers only the utils. startRecording.ts is the highest-churn file and is at 47% lines / 34% branches locally.

Where

  • src/tools/startRecording.ts:237, 450-461, 466-511, 538, 654
  • src/__tests__/triggers.test.ts:41-54

Impact

If a refactor or the SDK clones args before the handler, armed recordings either re-prompt (and fail when no one is there) or, worse, a change to the WeakSet logic lets an unarmed call skip consent.

Suggested fix

Extend src/__tests__/startRecording.test.ts (fake spawn) with an elicitation-capable client (the pattern in src/__tests__/consentLogging.test.ts:76-77) and mocked window/text checks:

  • startWhen {}: isError "startWhen needs window and/or text."
  • startWhen {window}: status "armed" with an arm- id, and consent asked exactly once.
  • When the condition is met, a session starts through the same handler and the elicitation handler is not called a second time.
  • A plain start_recording after an arm still prompts (approval does not leak).
  • Consent declined at arm: isError, and no arm is registered.
  • fire() returning isError: arm status "failed" with that error text.
  • stopWhen text met: the session stops with the stopWhen reason; a session that ends first aborts the watcher.

Getting started

  • Relevant files: src/tools/startRecording.ts, src/utils/triggers.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: M. audit-key: testing|src/tools/startRecording.ts|armRecording

Lenguaje dominante
TypeScript
Estrellas
1
Forks
4
Merge medio
14 h 8 min
PR fusionados (30 d)
48

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/screencast-mcp

Todos los issues de TMHSDigital/screencast-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.