Let pipeline and its recipes blur on-screen secrets (OCR scan) in the same call

Aberta
#341 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
45/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
typescript

Direção de pesquisa

Start with src/tools/pipeline.ts and src/utils/recipes.ts, then read src/cli.ts around redactCopy and src/utils/ocrScan.ts to understand the existing OCR flow. Run npm test to see the project’s current checks. Done means pipeline redaction and recipe options can scan source frames for secrets and turn matches into timed regions, with the CLI logic shared as described; the default behavior for recipes remains an open question.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

effort: medium enhancement priority: high

Summary

The pipeline redact op takes only explicit regions, and the pr_demo / tutorial / social_reel recipes never scan for secrets. The OCR-scan-then-blur flow exists, but only as private CLI code (redactCopy). Making a demo shareable safely therefore takes find_text, then redact_region (a full re-encode), then pipeline.

Where

  • src/tools/pipeline.ts:65-71 (redact op schema)
  • src/utils/recipes.ts:30-60
  • src/cli.ts:591-630 (redactCopy: find_text { scanEverySec, query: DEFAULT_SECRET_PATTERN, regex, redact: true } then redact_region)

Impact

The main "make this shareable" path can publish a token that showed on screen unless the agent remembers a separate two-tool pass, which costs an extra re-encode.

Proposal

Add secrets?: boolean | { pattern?: string } to the pipeline redact op, and a redactSecrets option on recipes, planned as a pre-pass like cut_idle and transcribe (pending probes): run scanVideoFrames + scanMatches on the source and turn the matches into timed redact regions. These are source-coordinate ops, which recipes already place before zoom/reframe (recipes.ts:67). Move redactCopy's logic into a util shared by the CLI, bug_report and pipeline.

Open question: should recipes turn it on by default when OCR is available (matching the consent-by-default stance of #266)?

Getting started

  • Relevant files: src/tools/pipeline.ts, src/utils/recipes.ts, src/cli.ts, src/utils/ocrScan.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: high. Effort: M. audit-key: enhancement|src/tools/pipeline.ts|redact.secrets

Linguagem predominante
TypeScript
Estrelas
1
Forks
4
Merge médio
14h 8min
PRs com merge (30d)
48

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TMHSDigital/screencast-mcp

Todas as issues de TMHSDigital/screencast-mcp

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.