Let pipeline and its recipes blur on-screen secrets (OCR scan) in the same call

未關閉
#341 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
45/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
typescript

研究方向

Start with src/tools/pipeline.ts and src/utils/recipes.ts, then read src/cli.ts around redactCopy and src/utils/ocrScan.ts to understand the existing OCR flow. Run npm test to see the project’s current checks. Done means pipeline redaction and recipe options can scan source frames for secrets and turn matches into timed regions, with the CLI logic shared as described; the default behavior for recipes remains an open question.

由索引模型根據 Issue 內容生成。

描述

effort: medium enhancement priority: high

Summary

The pipeline redact op takes only explicit regions, and the pr_demo / tutorial / social_reel recipes never scan for secrets. The OCR-scan-then-blur flow exists, but only as private CLI code (redactCopy). Making a demo shareable safely therefore takes find_text, then redact_region (a full re-encode), then pipeline.

Where

  • src/tools/pipeline.ts:65-71 (redact op schema)
  • src/utils/recipes.ts:30-60
  • src/cli.ts:591-630 (redactCopy: find_text { scanEverySec, query: DEFAULT_SECRET_PATTERN, regex, redact: true } then redact_region)

Impact

The main "make this shareable" path can publish a token that showed on screen unless the agent remembers a separate two-tool pass, which costs an extra re-encode.

Proposal

Add secrets?: boolean | { pattern?: string } to the pipeline redact op, and a redactSecrets option on recipes, planned as a pre-pass like cut_idle and transcribe (pending probes): run scanVideoFrames + scanMatches on the source and turn the matches into timed redact regions. These are source-coordinate ops, which recipes already place before zoom/reframe (recipes.ts:67). Move redactCopy's logic into a util shared by the CLI, bug_report and pipeline.

Open question: should recipes turn it on by default when OCR is available (matching the consent-by-default stance of #266)?

Getting started

  • Relevant files: src/tools/pipeline.ts, src/utils/recipes.ts, src/cli.ts, src/utils/ocrScan.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: high. Effort: M. audit-key: enhancement|src/tools/pipeline.ts|redact.secrets

主要語言
TypeScript
星號
1
分支
4
平均合併
14 小時 8 分鐘
30 天內合併 PR
48

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/screencast-mcp 的其他 Issue

查看 TMHSDigital/screencast-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。